fix(INJI-329): fix received card expand view and redirect the user to history screen after VC transfer #799
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
PuBHARGAVI
commented
Sep 7, 2023
•
PuBHARGAVI
commented
- If we click on Received card the detailed view of VC will be opened
- On the verifier after closing the VC transfer success popup the user will stay in the Incoming card screen and if the user clicks
- on "View Received Card" the user will be navigated to Received cards screen and in this screen if click on back button user will be redirected to Home screen
- on "back button" the user will be navigated to Receive card screen(QR code screen)
…how the expanded view of received card Onboarding is used to check whether we need to show the intro sliders or not now it is handled differently in AppLayout
tilak-puli
reviewed
Sep 7, 2023
| states: { | ||
| checkingOnboardingStatus: { |
There was a problem hiding this comment.
Why is the onboarding flow removed?
There was a problem hiding this comment.
In the old code we were using Onboarding status variable to decide whether we need to show the intro sliders in the MyVCs screen or not and when the app is installed and download the first VC we are setting that variable to true considering that onboarding is completed but there is a issue with this approach -
on the verifier side if we click on the received card we are creating new instance of MyVCS machine and it checks whether onboarding is completed or not since we didn't download the new vc that variable is not set to true and it will go into "Onboarding" state and inside this state there is no "VIEW_VC" event and the received card detailed view is failing because of this.
Now we are checking whether onboarding is done or not by checking if language preference is done or not so onboarding flow is not required
| @@ -52,7 +52,7 @@ export type MainBottomTabParamList = { | |||
| activeTab: number; | |||
| }; | |||
| Scan: undefined; | |||
| History: undefined; | |||
| history: undefined; | |||
There was a problem hiding this comment.
- Can we have consistent naming for routes? Scan is starting with capital letter while others are not
- Can we reuse this value in initialised of tab screen at line number 36 also? to avoid mismatch for all routes?
There was a problem hiding this comment.
Done, extracted the bottom tab, scan and request screen names into separate file to maintain the consistency
| @@ -58,7 +58,7 @@ export function useRequestLayout() { | |||
| ); | |||
| useEffect(() => { | |||
| if (isDone) { | |||
| navigation.navigate('History'); | |||
| navigation.navigate('history'); | |||
There was a problem hiding this comment.
for users, Immediately navigating to history screen might be unexpected as he would want to see the VC that he has received before moving to different screen
There was a problem hiding this comment.
Confirmed with @Kratitva regarding this, After closing the success popup we will be in the incoming card screen and only if the user clicks on View received card the user will be redirected to Received cards screen and if the user click on back button they will be redirected to QR code screen. I will make changes in the code
…g the success popup redirect the user to received cards screen if user clicks on view received card button and QR code screen if clicks on back button
…s into separate file to maintain the consistency
vijay151096
reviewed
Sep 11, 2023
screens/Scan/ScanLayoutController.ts
Outdated
| @@ -203,13 +200,13 @@ export function useScanLayout() { | |||
|
|
|||
| useEffect(() => { | |||
| if (isDone) { | |||
| navigation.navigate('home', { activeTab: 0 }); | |||
| navigation.navigate(BOTTOM_TAB_ROUTES.home(0).name); | |||
There was a problem hiding this comment.
can you please check, if activeTab plays any role here, if not please remove it from the routeConstants file as well.
There was a problem hiding this comment.
done as discussed i have removed it from routeConstants as it not being used. Before New UI merge we have 3 different tabs in home screen and the active tab variable is being used to display the current active tab and now we are maintaining different screens for all the tabs so activeTab is not required.
we can remove it from the other files as part of clean up task
… being used before new UI merge we have 3 different tabs in home screen and activeTab is used for displaying the current active tab
…d-card-expand-view and resolve conflicts
swatigoel
approved these changes
Sep 12, 2023
adityankannan-tw
pushed a commit
to tw-mosip/inji-wallet
that referenced
this pull request
Sep 12, 2023
… history screen after VC transfer (mosip#799) * fix(INJI-329): remove onboarding related code from MyVcs machine to show the expanded view of received card Onboarding is used to check whether we need to show the intro sliders or not now it is handled differently in AppLayout * fix(INJI-329): redirect the user to the history screen after successfull vc share * fix(INJI-329): show incoming card screen on the verifier after closing the success popup redirect the user to received cards screen if user clicks on view received card button and QR code screen if clicks on back button * refactor(INJI-329): extract bottom tab, scan and request screen names into separate file to maintain the consistency * refactor(INJI-329): remove activeTab from routeConstants as it is not being used before new UI merge we have 3 different tabs in home screen and activeTab is used for displaying the current active tab
vijay151096
pushed a commit
to tw-mosip/inji-wallet
that referenced
this pull request
Sep 15, 2023
… history screen after VC transfer (mosip#799) * fix(INJI-329): remove onboarding related code from MyVcs machine to show the expanded view of received card Onboarding is used to check whether we need to show the intro sliders or not now it is handled differently in AppLayout * fix(INJI-329): redirect the user to the history screen after successfull vc share * fix(INJI-329): show incoming card screen on the verifier after closing the success popup redirect the user to received cards screen if user clicks on view received card button and QR code screen if clicks on back button * refactor(INJI-329): extract bottom tab, scan and request screen names into separate file to maintain the consistency * refactor(INJI-329): remove activeTab from routeConstants as it is not being used before new UI merge we have 3 different tabs in home screen and activeTab is used for displaying the current active tab
swatigoel
added a commit
that referenced
this pull request
Sep 25, 2023
* refator(INJI-172): [Kiruthika] modify storage limit reached error message while adding or receiving card Issue Link https://mosip.atlassian.net/browse/INJI-172 * refator(INJI-172): [Kiruthika] add storage limit reached error message in spanish locale Issue Link https://mosip.atlassian.net/browse/INJI-172 * refator(INJI-172): [Kiruthika] move storage limit reached check function to storage class Issue Link https://mosip.atlassian.net/browse/INJI-172 * refator(INJI-172): [Kiruthika] add missing storage limit reached error message in strings.json file Issue Link https://mosip.atlassian.net/browse/INJI-172 * fix(INJI-206): [Vijay] remove vc from RNFS when vc metadata is removed from MMKV * refator(INJI-172): [Kiruthika] extract service and action Issue Link https://mosip.atlassian.net/browse/INJI-172 * refator(INJI-172): [Kiruthika] remove MB from min storage limit property name Issue Link https://mosip.atlassian.net/browse/INJI-172 * refator(INJI-172): [Kiruthika] extract function for displayng storage limit reached error Issue Link https://mosip.atlassian.net/browse/INJI-172 * fix(INJI-172): [Kiruthika] show storage limit popup on minimum storage limit reached criteria when bluetooth is off Issue Link https://mosip.atlassian.net/browse/INJI-172 * Test check * refator(INJI-172): [Kiruthika] rename the config key of storage limit Issue Link https://mosip.atlassian.net/browse/INJI-172 * Calculate HMAC and store Encrypted HMAC in Database * Revert Test Check * fix(INJI-212): [Vijay] fix qrlogin success popup redirection to history issue and vc sharing in progress screen issue * Change error pop up text in my vc's tab for tampered data * Revert english json changes * refator(INJI-172): [Kiruthika] extract service and action Issue Link https://mosip.atlassian.net/browse/INJI-172 * refator(INJI-172): [Kiruthika] replace equality check of boolean with type conversion Issue Link https://mosip.atlassian.net/browse/INJI-172 * Add encoding for decryption of HMAC * [Release 03-07-2023]fix:sharing timeout message displaying always * feat(#162): [Tilak|Pooja] remove unnecessary style from purple * [Release 03-07-2023]fix:sharing timeout message displaying always * [Release 03-07-2023]fix:navigation to history tab after successfully receiving VC * [Release 03-07-2023]fix:navigation to history tab after successfully receiving VC * [Release 03-07-2023]fix:navigation to history tab after successfully receiving VC * refator(INJI-182): [Kiruthika] send app id as X-AppId in header in the API requests Issue Link https://mosip.atlassian.net/browse/INJI-182 * fix(INJI-210): [Bhargavi] show the home screen after closing the success status overlay Issue Link https://mosip.atlassian.net/browse/INJI-210 * feat(#162): [Tilak|Pooja] extract app id constants. * refator(INJI-182): [Kiruthika] send app id in header only for the residentmobileapp API requests Issue Link https://mosip.atlassian.net/browse/INJI-182 * feat(#INJI-178) [Adityan] calculate and store encrypted HMAC hash of vc's metadata in database * feat(#INJI-178) [Adityan] calculate and store encrypted HMAC hash of vc's metadata in database and fix * Refactor the code and remove unused params * Refactor the code and remove unused parameters * feat(#162): [Tilak|Pooja] fix merge issue in hindi and format app id dictionary * Refactor the code and remove debug logs * feat(#162): [Tilak|Pooja] remove unused parameters in settings.ts * feat(INJI-149): add a popup when keychain fails to get password Reason: when keychain.getGenericPassword errors due to a false/falsy response, the state machine goes ahead and clears the MMKV store and the VC directory as without the key the encrypted data is not meaningful, it may so happen that the keychain/keystore is not unlocked yet as most modern mobile OSes can choose to lock access to it when the phone is locked Fix: earlier the state machine would go and clear the datastores without user intervention, this fix will give the user a prompt if encrypted VCs exist on app-data and allow user to try reading the keychain once again before silently deleting everything Co-authored-by: KiruthikaJeyashankar <[email protected]> Co-authored-by: Alka <[email protected]> * feat(INJI-149): add DualMessageOverlay component details about the component: - has two buttons tryAgain & cancel each occupying half the space in the row - kludge: uses similar styling for both themes - TODO: override the width styles in-place instead - this component should not be used for production as this is strictly temporary for narrowing down in on bugs Other changes: - removed additional button from original MessageOverlay component * fix(INJI-149): remove unavailable action from store.ts * chore: add missed out Podfile.lock changes * feat(INJI-149): remove extra button component of half width * feat(INJI-149): make DualMessageOverlay button gradient type Co-authored-by: <[email protected]> * chore: add check for Verifiable document store init other changes: - add Podfile.lock - remove debug logs * chore: bump up the tuvali version to v0.4.2 for release 18-07-2023 * fix: remove double quotes to the margin top property in send vc screen * feat(#162): [Tilak] fix ios logout crash by navigating on timeout * feat(#162): [Tilak] fix ios logout crash by navigating on timeout * fix(INJI-178): check for tampered VC without considering pinned state Issue Link https://mosip.atlassian.net/browse/INJI-178 * refactor: [Kiruthika | Dhivya] fix type warnings * fix(INJI-223): show the camera in scan screen while sharing the VC and click on scan icon Issue Link https://mosip.atlassian.net/browse/INJI-223 * fix version code error for internal build workflow (#761) * chore: update pod deps' to match development team of 1st project * feat(inji-214): [Dhivya|Tilak] integrate the secure store * feat[#211]:[Pooja] fix turncated passcode and confirm password button * feat[#211]:[Pooja] fix truncated histroy title text in iOS * feat(inji-214): [Dhivya|Tilak] conditional check added for platform * feat(inji-214): [Dhivya] modified state machine for generating keypair * feat[#211]:[Pooja] fix multiple error being displayed when the vc binding fails * fix(INJI-223): disconnect the device while sharing the VC and click on tab icons except scan icon Issue Link https://mosip.atlassian.net/browse/INJI-223 * feat[#211]:[Pooja] fix download card button styles * feat(inji-214): [Dhivya|Tilak] add logstate for vcitem state machine (cherry picked from commit 7001679cdd6f46dfc5a60474f30284292e69b888) * version code for beta build in pipeline * feat(inji-214): [Dhivya|Tilak] use Secure key store to sign jwt for auth * feat[#211]:[Pooja] add error message when VC activation fails in kebab pop up * chore(INJI-216): bump up tuvali version to v0.4.3 * feat[#225]:[Pooja] fix about inji url in about page * chore(INJI-216): bump up tuvali version to v0.4.3 * chore(INJI-216): update podlock file with the correct tuvali version * feat(inji-214): [Dhivya|Tilak] use sdk hmac method to create hmac for vc key * feat(inji-214): [Tilak|Dhivya] refactor hmac functionality * feat(inji-214): [Dhivya|Tilak] modify generatehmac function definition * refactor(INJI-223): get the scan string from route config to keep it consistent Issue Link https://mosip.atlassian.net/browse/INJI-223 * feat[#211]:[Pooja] refactor onCancel Co-authored-by: Harsh Vardhan <[email protected]> * feat(inji-175): show warning message to user on android hardware keystore * feat(inji-175): refactor the files * feat(inji-214): [Dhivya|Tilak] use sdk to create signature * feat:(inji-175) show warning message when device keystore not supports * fix(inji-175): resolve conflicts * feat(inji-175): locales changes for hardware keystore not exists warning text * feat(INJI-222): add popup for error in decryption * feat(INJI-222): wrap app init component & popups * feat(INJI-222): propagate event from _store to app state machine Co-authored-by: PuBHARGAVI <[email protected]> * feat(inji-175): modify arabic title locale * chore(INJI-222): move error msg text to errors obj * feat(inji-175): update mosip package name * Implemented Receive Card & Received Cards options in Settings * Fixed all the locals * fix(inji-175): modify variable name and refactor existing code * [INJI-69]fix:The mobile camera is not opening on the scan page when the flight mode is turned * [INJI-69]fix:The mobile camera is not opening on the scan page when the flight mode is turned * [INJI-69]fix:The mobile camera is not opening on the scan page when the flight mode is turned * [Inji-248]fix:The audit for deleting the VC is not logged in the history * fix:naming conventions, removed log and values in locals * Update .project * Initial commit 07-08-2023 * [INJI-249]fix:Back button from the ellipsis page not working on the mobile * Inplemented INJI Tour Guide in settings * Set navigation from auth to home screen * feat(inji-214): [Dhivya|Tilak] Update encryption and decryption to call SecureKeystore sdk with biometric auth enabled * Resolved the comments * Updated 'Get Started' button text in hindi locals * feat(INJI-238): handling errors when invalidate keys of biometric * feat(INJI-238): add reset keys action * fix(INJI-149): skip showing read-error popup on launch * feat(inji-238): fetch enabled device biometric from sdk * chore: disallow expansion of received cards * feat(inji-214): [Dhivya|Tilak] fix app events RESET_KEY_INVALIDATE_ERROR_DISMISS not accessible issue * feat(inji-214): [Dhivya|Tilak] fix generate key pair failing due to wrong count of arguments * fix(INJI-192): add error message translations for HMAC calculation * feat(inji-214): [Dhivya|Tilak] Update biometric popup text * feat(inji-238): translations added for biometric text * feat(inji-214): [Dhivya|Tilak] fix language not getting updated for auth popup * fix(INJI-286):Show VC detailed view in the Received Vc screen * fix(INJI-286):Show VC detailed view in the Received Vc screen * fix(INJI-285): Added the flip camera buton in the scan screen * fix(INJI-262):pinned VC's audit logs are missing * fix(INJI-262):pinned VC's audit logs are missing * fix(INJI-214): secure-keystore version changes * fix(INJI-214): fixed Podfile.lock merge issue * refactor(INJI-214): refactor the code * fix(INJI-262):pinned VC's audit logs are missing * fix(INJI-211[1]): improve isPinned evaluation of (un)pinned VCs (#102) * fix(INJI-211[1]): Pin/unpin card not working intermittently * fix(INJI-263):camera is not opening when vc is pinned * fix(INJI-262):pinned VC's audit logs are missing * fix(INJI-262):pinned VC's audit logs are missing * [INJI-69]fix:The mobile camera is not opening on the scan page when the flight mode is turned * feat(inji-238): handle key not found error after key invalidation * feat(inji-238): reinit app machine on dismiss of invalidation popup * fix(INJI-262):pinned VC's audit logs are missing * fix(INJI-263):camera is not opening when vc is pinned * feat(INJI-255): hash the passcode and store in mmkv * feat(inji-238): use a dummy key to request biometric auth everytime user opens the app * feat(inji-238): revert tamperedErrorMessageString value * feat(inji-293): use jetify to fix react-native/location bundle issue * feat(inji-293): fix jetify running location * Inji 282 disable camera error (#775) * fix(INJI-282): Correct error message will be displayed when camera is disabled * fix(INJI-260):app not aligned properly with the smaller display screen (#778) * Fixed tab elements which are still in english (#779) * feat(INJI-202): hash uin/vid to store in mmkv and file storage (#780) * feat(INJI-202): hash uin/vid to store in mmkv and file storage * feat(INJI-202): refactor to store salt in constants * feat(INJI-202): refactor argon2i salt and add function to get MMKV data * feat(INJI-202): refactor to get mkkv data method --------- Co-authored-by: Pooja Babusingh <[email protected]> * fix(inji-253): set thumbprint on wallet binding for e-signet login * fix(INJI-296): label mismatch in language files (#772) * fix(INJI-262):pinned VC's audit logs are missing * fix(INJI-286): expand received card popup on click (#783) Revert "chore: disallow expansion of received cards" This reverts commit 038b6e4. * chore(INJI-304): bump up secure keystore version to v0.1.1 * chore(INJI-304): bump up tuvali version to v0.4.4 * Inji 304 update tuvali and secure keystore version (#784) * chore(INJI-304): bump up secure keystore version to v0.1.1 * chore(INJI-304): bump up tuvali version to v0.4.4 --------- Co-authored-by: dhivya0413 <[email protected]> * fix(INJI-304): tuvali & secure-keystore version update in package-lock Co-authored-by: Pooja Babusingh <[email protected]> * fix(INJI-282) Cross button of pop-up will navigate to home (#786) * fix(INJI-282) Cross button of pop-up will navigate to home * Icon made as pressble part * fix(INJI-253): set thumbprint for custom secure keystore for qr login (#787) * chore(INJI-303): update android target and compile sdk to API level 33 (#790) * bump up react-native-gesture-handler version to 2.5.0 * remove RNGestureHandlerEnabledRootView as it is not needed in new version of react-native-gesture-handler * package-lock file update (#791) * chore(INJI-303): update android target and compile sdk to API level 33 * bump up react-native-gesture-handler version to 2.5.0 * remove RNGestureHandlerEnabledRootView as it is not needed in new version of react-native-gesture-handler * chore(INJI-303): update package-lock file * feat(INJI-311): add test id for vc download flow (#792) Co-authored-by: Pooja Babusingh <[email protected]> * Inji 311 rename testId to testID (#794) * feat(INJI-311): add test id for vc download flow * feat(INJI-311): rename testId to testID --------- Signed-off-by: PoojaBabusing <[email protected]> Co-authored-by: Pooja Babusingh <[email protected]> * fix(INJI-247):The VC's three dots elipsise layout is not proper (#789) * fix(INJI-247):The VC's three dots elipsise layout is not proper * Update constants.ts * fix(INJI-247):The VC's three dots elipsise layout is not proper * fix(INJI-247):The VC's three dots elipsise layout is not proper * fix(INJI-268): Adjusted alignment of page headers properly (#793) * fix(INJI-268): Adjusted alignment of page headers properly * Update styles in purple theme too * feat(INJI-334): add testID for VC download flow * feat(INJI-334): add numberOfLines prop to text component * feat(INJI-334): add testID for resendCode and getItHere * feat(INJI-334): add id for pin input * feat(INJI-334): refactor pinInput to take testID prop * feat(INJI-334): rename testID function to testIDProps * testIds for intro and language screens (#803) * feat(INJI-335): add testIds for intro and language screens * feat(INJI-336): add testIds for language item and rename introSlide id --------- Co-authored-by: Pooja Babusingh <[email protected]> * feat(INJI-336): add testIds for setPassword and confirmPassword screens (#804) Co-authored-by: Pooja Babusingh <[email protected]> * fix(Inji-290): Modified share timeout hint as per wireframe (#800) * fix(INJI-290): modified-share-timeout-hint-as-per-wireframe * Updated the locals with respective texts in progressing screen * fix(INJI-289): Modified the face authentication layout as per wire-frame (#802) * fix(INJI-289): Adjusted face authentication layout as per UI/UX * Replaced capture-icon from theme styles to provides png images * fix(INJI-134):New mosip logo is updated in the inji app (#801) * fix(INJI-134):New mosip logo is updated in the inji app * fix(INJI-134):New mosip logo is updated in the inji ios * fix(INJI-337)testID for home screen and settings screen (#805) * fix(INJI-337)testID for home screen and settings screen * fix(INJI-337)testID for home screen and settings screen * feat(INJI-337): refactor testID for home screen and settings screen * feat(INJI-337): refactor testID for home screen and settings screen * feat(INJI-337): refactor testID for home screen and settings screen * feat(INJI-338): add testID for settings page (#817) * fix(INJI-329): fix received card expand view and redirect the user to history screen after VC transfer (#799) * fix(INJI-329): remove onboarding related code from MyVcs machine to show the expanded view of received card Onboarding is used to check whether we need to show the intro sliders or not now it is handled differently in AppLayout * fix(INJI-329): redirect the user to the history screen after successfull vc share * fix(INJI-329): show incoming card screen on the verifier after closing the success popup redirect the user to received cards screen if user clicks on view received card button and QR code screen if clicks on back button * refactor(INJI-329): extract bottom tab, scan and request screen names into separate file to maintain the consistency * refactor(INJI-329): remove activeTab from routeConstants as it is not being used before new UI merge we have 3 different tabs in home screen and activeTab is used for displaying the current active tab * feat(INJI-340): add testID for VC Detailes (#809) * fix(INJI-340): Added testIDs for the VC Detailes * Added testIDProps, testId's in TextItem component & for labels in VcDetailes. * Changes the testID's to titles & values * feat(INJI-337): refactor testID for home screen and settings screen (#820) * feat(INJI-339): Add testID's for VC Card in home page (#812) * fix(INJI-339): Added test for the VC card on the home page * fix(INJI-339): Added testId for ellipsis(kebab) * Added testID's in kebab popUp options * Adjusted the UI errors after adding testID's * Renamed Kebab popUp title testId * Renamed Kebab popUp title testId * fix(INJI-339): Added testId for three-dots icon in the VC Card (#825) * fix(INJI-339): Added test for the VC card on the home page * fix(INJI-339): Added testId for ellipsis(kebab) * Added testID's in kebab popUp options * Adjusted the UI errors after adding testID's * Renamed Kebab popUp title testId * Renamed Kebab popUp title testId * testId was added to the three-dots in Vc Card * Inji 360 Support different host for mimoto and esignet (#829) * feat(INJI-360): Add esignet host as env variable and use in QR login flow. * feat(INJI-360): Fix compile error. * chore(INJI-360): support esignet and mimoto base url in workflows for Android and iOS * chore(INJI-360): add ESIGNET_HOST in Fastfile for android. * chore(INJI-360): remove unnecessary env variables from ios build workflow. * [INJI-195] Upgrade React native version to 0.71.8 (#824) * chore(INJI-195): upgrade react native version and dependencies * chore(INJI-195): upgrade expo version and dependencies * chore(INJI-195): modify associated files on version upgrade * chore(INJI-295): fixed react native flipper and patch packages * chore(INJI-195): fix for expo prebuild * chore(INJI-195): expo linked to android/ios projects * chore(INJI-195): update metro config * chore(INJI-195): fix ios build with mmkv storage patch * chore(INJI-195): gradle version modified * chore(INJI-195): fixed rn version 0.71.8 due to mmkv library issue * chore(INJI-195): removed files in android * chore(INJI-195): fix 0.71.8 for iOS project through pods with expo linking * chore(INJI-195): fix for custom fonts added through pods due to rn linkage * chore(INJI-195): fix for removing assets.car generated from pods * Modify Node version in pipeline (#806) * chore(INJI-195): fix for android splash screen not shown up * chore(INJI-195): upgraded to node 18 in pipeline * chore(INJI-195): add the pod install twice to remove duplicates via script workaround (#807) Signed-off-by: dhivya0413 <[email protected]> * INJI-195 Set the signing team for iOS (#810) * chore(INJI-195): add the pod install twice to remove duplicates via script workaround * chore(INJI-195): set the signing team for ios build --------- Signed-off-by: dhivya0413 <[email protected]> * Modify github runner to self hosted runner (#811) * chore(INJI-195): add the pod install twice to remove duplicates via script workaround * chore(INJI-195): set the signing team for ios build * chore(INJI-195): set the self hosted runner for ios build --------- Signed-off-by: dhivya0413 <[email protected]> * Modify self hosted runner to github hosted runner (#813) * chore(INJI-195): add the pod install twice to remove duplicates via script workaround * chore(INJI-195): set the signing team for ios build * chore(INJI-195): set the self hosted runner for ios build * chore(INJI-195): modify the self hosted to github hosted runner --------- Signed-off-by: dhivya0413 <[email protected]> * chore(INJI-195): modify the self hosted to github hosted runner * chore(INJI-195): set the code signing identity for ios build * chore(INJI-195): assigned app icon files to asset --------- Signed-off-by: dhivya0413 <[email protected]> Signed-off-by: Swati Goel <[email protected]> Co-authored-by: Swati Goel <[email protected]> * fix(INJI-371): View-activity-log-screen-header-resolved (#831) * feat(INJI-333): Add a job to upload apk to Github actions in internal build (#832) * add testIds for pincard and vc activation (#833) * feat(INJI-375): add testIds for pincard and vc activation * feat(INJI-375): rename testIds vc activation and remove vc * feat(INJI-375): rename testIds vc activation and remove vc to warningMsg --------- Co-authored-by: Pooja Babusingh <[email protected]> * feat - add injitest directory. (#834) * Revert "feat(INJI-333): Add a job to upload apk to Github actions in internal build (#832)" (#835) This reverts commit 5c0ac9d. * Add a job to upload apk to Github Actions (#836) * feat(INJI-333): Add a job to upload apk to Github actions in internal build * fix(INJI-333): Add a job to upload to Github actions * Add support to change mimoto and esignet host url under credential registry (#837) * feat(INJI-360): Add esignet host as env variable and use in QR login flow. * feat(INJI-360): Fix compile error. * chore(INJI-360): support esignet and mimoto base url in workflows for Android and iOS * chore(INJI-360): add ESIGNET_HOST in Fastfile for android. * chore(INJI-360): remove unnecessary env variables from ios build workflow. * feat(INJI-360): Add setting to change esignet host url under credetntial registry. --------- Signed-off-by: Swati Goel <[email protected]> * [Inji 267] sunbird telemetry configuration (#838) * feat(INJI-267): add and export deviceId constant in constants file Use react-native-device-info library to get the unique identifier for each and every device * refactor(INJI-267): extracts AppId global variable into a global variable file and renames it to __AppId * refactor(INJI-267): extracts inji version and tuvali version handling into global variable file * feat(INJI-267): add telemetry configuration in the application * feat(INJI-267): generate unique session id for every session of the app After launching the app until we kill the app we consider it as a single session * feat(INJI-267): add start and end telemetry events for the QR login success flow * feat(INJI-267): pass session id value in sunbird config * feat(INJI-267): add start and end telemetry events for the VC sharing success flow * feat(INJI-267): add start and end telemetry events for the VC activation success flow * refactor(INJI-267): change QR login, VC share telemetry events type * refactor(INJI-267): extract generateSessionId function, deviceId into global variables file * feat(INJI-267): adds device related information in the config value * feat(INJI-267): add and export deviceId constant in constants file Use react-native-device-info library to get the unique identifier for each and every device * refactor(INJI-267): extracts AppId global variable into a global variable file and renames it to __AppId * refactor(INJI-267): extracts inji version and tuvali version handling into global variable file * feat(INJI-267): add telemetry configuration in the application * feat(INJI-267): generate unique session id for every session of the app After launching the app until we kill the app we consider it as a single session * feat(INJI-267): add start and end telemetry events for the QR login success flow * feat(INJI-267): pass session id value in sunbird config * feat(INJI-267): add start and end telemetry events for the VC sharing success flow * feat(INJI-267): add start and end telemetry events for the VC activation success flow * refactor(INJI-267): change QR login, VC share telemetry events type * refactor(INJI-267): extract generateSessionId function, deviceId into global variables file * feat(INJI-267): adds device related information in the config value * feat(INJI-267): add selected language in global variables file to pass it into sunbird config * feat(INJI-267): updates config structure and add AppInfo event * feat(INJI-267): create dummy end event data to make the schema and send AppInfo Event on app launch * feat(INJI-267): add and export deviceId constant in constants file Use react-native-device-info library to get the unique identifier for each and every device * refactor(INJI-267): extracts AppId global variable into a global variable file and renames it to __AppId * refactor(INJI-267): extracts inji version and tuvali version handling into global variable file * feat(INJI-267): add telemetry configuration in the application * feat(INJI-267): generate unique session id for every session of the app After launching the app until we kill the app we consider it as a single session * feat(INJI-267): add start and end telemetry events for the QR login success flow * feat(INJI-267): pass session id value in sunbird config * feat(INJI-267): add start and end telemetry events for the VC sharing success flow * feat(INJI-267): add start and end telemetry events for the VC activation success flow * refactor(INJI-267): change QR login, VC share telemetry events type * refactor(INJI-267): extract generateSessionId function, deviceId into global variables file * feat(INJI-267): adds device related information in the config value * feat(INJI-267): add and export deviceId constant in constants file Use react-native-device-info library to get the unique identifier for each and every device * feat(INJI-267): add telemetry configuration in the application * feat(INJI-267): pass session id value in sunbird config * refactor(INJI-267): change QR login, VC share telemetry events type * refactor(INJI-267): extract generateSessionId function, deviceId into global variables file * feat(INJI-267): adds device related information in the config value * feat(INJI-267): add selected language in global variables file to pass it into sunbird config * feat(INJI-267): updates config structure and add AppInfo event * feat(INJI-267): create dummy end event data to make the schema and send AppInfo Event on app launch * feat(INJI-267): bump up react-native-localize and remove unnecessary code * feat(INJI-267): remove some unused imports and unnecessary formattings * feat(INJI-267): remove unnecessary formattings * feat(INJI-267): extracts obsrv host in an env variable * feat(INJI-267): add env variable in react-native-dot-env index file * feat(INJI-267): bump up react-native-localize --------- Signed-off-by: Swati Goel <[email protected]> Co-authored-by: PuBHARGAVI <[email protected]> Co-authored-by: Swati Goel <[email protected]> * [Inji 267] sunbird telemetry configuration (#843) * feat(INJI-267): add and export deviceId constant in constants file Use react-native-device-info library to get the unique identifier for each and every device * refactor(INJI-267): extracts AppId global variable into a global variable file and renames it to __AppId * refactor(INJI-267): extracts inji version and tuvali version handling into global variable file * feat(INJI-267): add telemetry configuration in the application * feat(INJI-267): generate unique session id for every session of the app After launching the app until we kill the app we consider it as a single session * feat(INJI-267): add start and end telemetry events for the QR login success flow * feat(INJI-267): pass session id value in sunbird config * feat(INJI-267): add start and end telemetry events for the VC sharing success flow * feat(INJI-267): add start and end telemetry events for the VC activation success flow * refactor(INJI-267): change QR login, VC share telemetry events type * refactor(INJI-267): extract generateSessionId function, deviceId into global variables file * feat(INJI-267): adds device related information in the config value * feat(INJI-267): add and export deviceId constant in constants file Use react-native-device-info library to get the unique identifier for each and every device * refactor(INJI-267): extracts AppId global variable into a global variable file and renames it to __AppId * refactor(INJI-267): extracts inji version and tuvali version handling into global variable file * feat(INJI-267): add telemetry configuration in the application * feat(INJI-267): generate unique session id for every session of the app After launching the app until we kill the app we consider it as a single session * feat(INJI-267): add start and end telemetry events for the QR login success flow * feat(INJI-267): pass session id value in sunbird config * feat(INJI-267): add start and end telemetry events for the VC sharing success flow * feat(INJI-267): add start and end telemetry events for the VC activation success flow * refactor(INJI-267): change QR login, VC share telemetry events type * refactor(INJI-267): extract generateSessionId function, deviceId into global variables file * feat(INJI-267): adds device related information in the config value * feat(INJI-267): add selected language in global variables file to pass it into sunbird config * feat(INJI-267): updates config structure and add AppInfo event * feat(INJI-267): create dummy end event data to make the schema and send AppInfo Event on app launch * feat(INJI-267): add and export deviceId constant in constants file Use react-native-device-info library to get the unique identifier for each and every device * refactor(INJI-267): extracts AppId global variable into a global variable file and renames it to __AppId * refactor(INJI-267): extracts inji version and tuvali version handling into global variable file * feat(INJI-267): add telemetry configuration in the application * feat(INJI-267): generate unique session id for every session of the app After launching the app until we kill the app we consider it as a single session * feat(INJI-267): add start and end telemetry events for the QR login success flow * feat(INJI-267): pass session id value in sunbird config * feat(INJI-267): add start and end telemetry events for the VC sharing success flow * feat(INJI-267): add start and end telemetry events for the VC activation success flow * refactor(INJI-267): change QR login, VC share telemetry events type * refactor(INJI-267): extract generateSessionId function, deviceId into global variables file * feat(INJI-267): adds device related information in the config value * feat(INJI-267): add and export deviceId constant in constants file Use react-native-device-info library to get the unique identifier for each and every device * feat(INJI-267): add telemetry configuration in the application * feat(INJI-267): pass session id value in sunbird config * refactor(INJI-267): change QR login, VC share telemetry events type * refactor(INJI-267): extract generateSessionId function, deviceId into global variables file * feat(INJI-267): adds device related information in the config value * feat(INJI-267): add selected language in global variables file to pass it into sunbird config * feat(INJI-267): updates config structure and add AppInfo event * feat(INJI-267): create dummy end event data to make the schema and send AppInfo Event on app launch * feat(INJI-267): bump up react-native-localize and remove unnecessary code * feat(INJI-267): remove some unused imports and unnecessary formattings * feat(INJI-267): remove unnecessary formattings * feat(INJI-267): extracts obsrv host in an env variable * feat(INJI-267): add env variable in react-native-dot-env index file * feat(INJI-267): bump up react-native-localize * feat(INJI-267): add telemetry sdk dependency in package.json --------- Signed-off-by: Swati Goel <[email protected]> Signed-off-by: Alka Prasad <[email protected]> Co-authored-by: PuBHARGAVI <[email protected]> Co-authored-by: Swati Goel <[email protected]> * style vcDetails page (#841) * feat(INJI-351): style vcDetails page * feat(INJI-351): add translations to fil lang and remove QRcode style --------- Co-authored-by: Pooja Babusingh <[email protected]> * Inji-344: Refactoring VC Key (#798) * feat(inji-344): Use VC Key class instead of separate functions for managing vc key * feat(inji-344): Use properties from VcKey Class instead of reading from vckey string * feat(inji-344): Rename vcKey to vcMetadata * feat(inji-344): Use vc's unique id or vckey instead of joined string of vc metadata * feat(inji-344): Use vc key instead of unique id to avoid confusion. Fix issues reg parsing vc metadata * feat(inji-344):fix redownloading issue Co-authored-by: Tilak <[email protected]> * feat(inji-344): Remove vc getting stored on update of pin status * feat(inji-344): update other vc's pin status to false when any vc is pinned * feat(inji-344): remove hash ID for UIN * feat(inji-344): revert google services json * feat(inji-344): remove mmkv logs added for debugging * feat(inji-344): fix received vcs not getting displayed on reopen of app * feat(inji-344): fix id not shown in revoke component --------- Co-authored-by: Sri Kanth Kola <[email protected]> * automation(MOSIP-28901-automation-framework): Framework created * feat(inji-267): update telemetry dep version to latest develop with rimraf fix (#848) * (INJI-350): Sync VC UI with wireframes (#845) * fix(INJI-350): Sync VC UI with wireframes * fix(INJI-350): fix minor styling changes * fix(INJI-350): fix merge conflicts and missed changes * fix(INJI-350): refactor the icon sizes and id numbers * fix(INJI-350): refactor the text sizes and labels * fix(INJI-350): add extrasmall size type to text component * fix(INJI-350): add extraSmall size type to text component * feat: download credentials from Esignet using openId4VCI (#851) * feat(INJI-245): dowload and view card via issuers Co-authored-by: Harsh Vardhan <[email protected]> * fix(INJI-245): remove vc from wallet Co-authored-by: Harsh Vardhan <[email protected]> * feat(INJI-245): pin card downloaded via eSignet * refactor(INJI-245): remove debug logs * refactor(INJI-245): rename vcItem related component to ExistingVcItem * refactor(INJI-245): add lock file modifications * refactor(INJI-245): add styles in purple theme for issuer related components * refactor(INJI-245): update VID for wallet binding usecase and issuer logo display in vc * refactor(INJI-245): remove duplicate loader component * refactor(INJI-245): remove unused props in vc details container --------- Co-authored-by: Harsh Vardhan <[email protected]> Co-authored-by: Vijay <[email protected]> * Inji-393: Make inner components visible to Appium (#853) * feat(INJI-393): add accessible prop to outer and inner components * feat: download credentials from Esignet using openId4VCI (#851) * feat(INJI-245): dowload and view card via issuers Co-authored-by: Harsh Vardhan <[email protected]> * fix(INJI-245): remove vc from wallet Co-authored-by: Harsh Vardhan <[email protected]> * feat(INJI-245): pin card downloaded via eSignet * refactor(INJI-245): remove debug logs * refactor(INJI-245): rename vcItem related component to ExistingVcItem * refactor(INJI-245): add lock file modifications * refactor(INJI-245): add styles in purple theme for issuer related components * refactor(INJI-245): update VID for wallet binding usecase and issuer logo display in vc * refactor(INJI-245): remove duplicate loader component * refactor(INJI-245): remove unused props in vc details container --------- Co-authored-by: Harsh Vardhan <[email protected]> Co-authored-by: Vijay <[email protected]> --------- Signed-off-by: adityankannan-tw <[email protected]> Co-authored-by: KiruthikaJeyashankar <[email protected]> Co-authored-by: Harsh Vardhan <[email protected]> Co-authored-by: Vijay <[email protected]> * add resend otp to wallet binding in kebabPopUp and ViewVc (#852) * feat(INJI-327): add resend otp to wallet binding in kebabPopUp and ViewVC * feat(INJI-327): update resend otp timer to 180 sec --------- Co-authored-by: Pooja Babusingh <[email protected]> * Feat(Inji-344): Fix Remove VC failure due to json parsing (#849) * feat(inji-344): Use VC Key class instead of separate functions for managing vc key * feat(inji-344): Use properties from VcKey Class instead of reading from vckey string * feat(inji-344): Rename vcKey to vcMetadata * feat(inji-344): Use vc's unique id or vckey instead of joined string of vc metadata * feat(inji-344): Use vc key instead of unique id to avoid confusion. Fix issues reg parsing vc metadata * feat(inji-344):fix redownloading issue Co-authored-by: Tilak <[email protected]> * feat(inji-344): Remove vc getting stored on update of pin status * feat(inji-344): update other vc's pin status to false when any vc is pinned * feat(inji-344): remove hash ID for UIN * feat(inji-344): revert google services json * feat(inji-344): remove mmkv logs added for debugging * feat(inji-344): fix received vcs not getting displayed on reopen of app * feat(inji-344): fix id not shown in revoke component * feat(inji-344): fix remove VC getting failed due to json parse issue * Merge branch 'develop' of https://github.com/mosip/inji --------- Co-authored-by: Sri Kanth Kola <[email protected]> * fix(inji-324): show the download popup until the card is loaded successfully in the UI (#839) * fix(INJI-324): show the download popup until the vc is downloaded and loaded successfully in the UI * refactor(INJI-324): remove unnecessary formatting changes in vc and vcitem files * fix(INJI-324): show download popup until all the VCs are successfully downloaded Until all the requested VCs are downloaded and also if we close and open the app and the VCs are not downloaded yet the download popup will be shown in the UI * refactor(INJI-324): remove unnecessary formatting changes * refactor(INJI-324): remove unnecessary format changes * feat(INJI-322): remove resend msg timer after timer ends (#855) Co-authored-by: Pooja Babusingh <[email protected]> * feat(INJI-404): Upload app file to actions * Revert "feat(INJI-404): Upload app file to actions" This reverts commit 54051a7. --------- Signed-off-by: PoojaBabusing <[email protected]> Signed-off-by: dhivya0413 <[email protected]> Signed-off-by: Swati Goel <[email protected]> Signed-off-by: Alka Prasad <[email protected]> Signed-off-by: adityankannan-tw <[email protected]> Co-authored-by: Kiruthika Jeyashankar <[email protected]> Co-authored-by: Vijay <[email protected]> Co-authored-by: vijay151096 <[email protected]> Co-authored-by: Sri Kanth Kola <[email protected]> Co-authored-by: Tilak Puli <[email protected]> Co-authored-by: PuBHARGAVI <[email protected]> Co-authored-by: PoojaBabusing <[email protected]> Co-authored-by: Harsh Vardhan <[email protected]> Co-authored-by: Alka <[email protected]> Co-authored-by: Dhivya <[email protected]> Co-authored-by: Pooja Babusingh <[email protected]> Co-authored-by: anil_majji <[email protected]> Co-authored-by: srikanth716 <[email protected]> Co-authored-by: Alka Prasad <[email protected]> Co-authored-by: Monobikash Das <[email protected]> Co-authored-by: Anil kumar M <[email protected]> Co-authored-by: Swati Goel <[email protected]> Co-authored-by: dhivya0413 <[email protected]> Co-authored-by: Sreenadh S <[email protected]> Co-authored-by: Tilak Puli <[email protected]> Co-authored-by: kamalsingh <[email protected]>
tilak-puli
pushed a commit
to tw-mosip/inji-wallet
that referenced
this pull request
Oct 10, 2023
… history screen after VC transfer (mosip#799) * fix(INJI-329): remove onboarding related code from MyVcs machine to show the expanded view of received card Onboarding is used to check whether we need to show the intro sliders or not now it is handled differently in AppLayout * fix(INJI-329): redirect the user to the history screen after successfull vc share * fix(INJI-329): show incoming card screen on the verifier after closing the success popup redirect the user to received cards screen if user clicks on view received card button and QR code screen if clicks on back button * refactor(INJI-329): extract bottom tab, scan and request screen names into separate file to maintain the consistency * refactor(INJI-329): remove activeTab from routeConstants as it is not being used before new UI merge we have 3 different tabs in home screen and activeTab is used for displaying the current active tab
tilak-puli
pushed a commit
to tw-mosip/inji-wallet
that referenced
this pull request
Oct 11, 2023
… history screen after VC transfer (mosip#799) * fix(INJI-329): remove onboarding related code from MyVcs machine to show the expanded view of received card Onboarding is used to check whether we need to show the intro sliders or not now it is handled differently in AppLayout * fix(INJI-329): redirect the user to the history screen after successfull vc share * fix(INJI-329): show incoming card screen on the verifier after closing the success popup redirect the user to received cards screen if user clicks on view received card button and QR code screen if clicks on back button * refactor(INJI-329): extract bottom tab, scan and request screen names into separate file to maintain the consistency * refactor(INJI-329): remove activeTab from routeConstants as it is not being used before new UI merge we have 3 different tabs in home screen and activeTab is used for displaying the current active tab Signed-off-by: Tilak Puli <[email protected]>
tilak-puli
pushed a commit
to tw-mosip/inji-wallet
that referenced
this pull request
Oct 11, 2023
… history screen after VC transfer (mosip#799) * fix(INJI-329): remove onboarding related code from MyVcs machine to show the expanded view of received card Onboarding is used to check whether we need to show the intro sliders or not now it is handled differently in AppLayout * fix(INJI-329): redirect the user to the history screen after successfull vc share * fix(INJI-329): show incoming card screen on the verifier after closing the success popup redirect the user to received cards screen if user clicks on view received card button and QR code screen if clicks on back button * refactor(INJI-329): extract bottom tab, scan and request screen names into separate file to maintain the consistency * refactor(INJI-329): remove activeTab from routeConstants as it is not being used before new UI merge we have 3 different tabs in home screen and activeTab is used for displaying the current active tab
tilak-puli
pushed a commit
to tw-mosip/inji-wallet
that referenced
this pull request
Oct 11, 2023
… history screen after VC transfer (mosip#799) * fix(INJI-329): remove onboarding related code from MyVcs machine to show the expanded view of received card Onboarding is used to check whether we need to show the intro sliders or not now it is handled differently in AppLayout * fix(INJI-329): redirect the user to the history screen after successfull vc share * fix(INJI-329): show incoming card screen on the verifier after closing the success popup redirect the user to received cards screen if user clicks on view received card button and QR code screen if clicks on back button * refactor(INJI-329): extract bottom tab, scan and request screen names into separate file to maintain the consistency * refactor(INJI-329): remove activeTab from routeConstants as it is not being used before new UI merge we have 3 different tabs in home screen and activeTab is used for displaying the current active tab Signed-off-by: Tilak Puli <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.