Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(INJI-205): Error handling in OIDC flow #878

Merged
merged 20 commits into from
Oct 10, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
20 commits
Select commit Hold shift + click to select a range
b57af95
feat(INJI-205): handle errors in OIDC flow in issuerMachine
vharsh Sep 28, 2023
256c036
feat(INJI-205): add support for request timeout for OIDC
vharsh Sep 28, 2023
53c540d
refactor(INJI-205): improve oidc error handling
vharsh Oct 5, 2023
84715a3
refactor(INJI-205): Check Internet before OIDC AuthZ
vharsh Oct 6, 2023
39e51a5
refactor(INJI-205): remove redundant error state
vharsh Oct 6, 2023
017009f
feat(INJI-205): use AbortController's signal timeout
vharsh Oct 9, 2023
fcf4204
refactor(INJI-205): rename variable and remove redundant comments
KiruthikaJeyashankar Oct 9, 2023
de7dfed
feat(INJI-205): handle invalid OIDC configs error
vharsh Oct 9, 2023
8e16ca0
feat(INJI-205): handle timeout error for vc download via issuer
KiruthikaJeyashankar Oct 9, 2023
198ac72
refactor(INJI-205): remove redundant storing of error message and type
KiruthikaJeyashankar Oct 9, 2023
b0c2f2c
refactor(INJI-205): move loadingReason update to diff action
vharsh Oct 9, 2023
bcd500f
refactor(INJI-205): rename state actions & extract consts
vharsh Oct 10, 2023
d9077ff
fix(INJI-205): reference errormessages from util in issuersMachine
KiruthikaJeyashankar Oct 10, 2023
6192c22
refactor(INJI-205): move common error const to consts file
KiruthikaJeyashankar Oct 10, 2023
a81f27a
refactor(INJI-205): rename action names
KiruthikaJeyashankar Oct 10, 2023
eb7396e
feat(INJI-205): move to prev screen on back btn press in error screen
KiruthikaJeyashankar Oct 10, 2023
41755bc
feat(INJI-205): use openId4VCIDownloadVCTimeout from config
KiruthikaJeyashankar Oct 10, 2023
9d3c9c2
feat(INJI-205): toggle on openID for VC
KiruthikaJeyashankar Oct 10, 2023
25c2bd6
refactor(INJI-205): use extracted error constant to avoid hardcoding
KiruthikaJeyashankar Oct 10, 2023
2e91aef
fix(INJI-205): vcDownloadTimeout config fetch
KiruthikaJeyashankar Oct 10, 2023
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .env
Original file line number Diff line number Diff line change
Expand Up @@ -21,4 +21,4 @@ DEBUG_MODE=false
APPLICATION_LANGUAGE=en

#Toggle for openID for VC
ENABLE_OPENID_FOR_VC=false
ENABLE_OPENID_FOR_VC=true
22 changes: 11 additions & 11 deletions machines/activityLog.typegen.ts
Original file line number Diff line number Diff line change
Expand Up @@ -2,31 +2,31 @@

export interface Typegen0 {
'@@xstate/typegen': true;
'internalEvents': {
'xstate.init': { type: 'xstate.init' };
internalEvents: {
'xstate.init': {type: 'xstate.init'};
};
'invokeSrcNameMap': {};
'missingImplementations': {
invokeSrcNameMap: {};
missingImplementations: {
actions: never;
delays: never;
guards: never;
services: never;
};
'eventsCausingActions': {
eventsCausingActions: {
loadActivities: 'REFRESH' | 'xstate.init';
prependActivity: 'STORE_RESPONSE';
setActivities: 'STORE_RESPONSE';
storeActivity: 'LOG_ACTIVITY';
};
'eventsCausingDelays': {};
'eventsCausingGuards': {};
'eventsCausingServices': {};
'matchesStates':
eventsCausingDelays: {};
eventsCausingGuards: {};
eventsCausingServices: {};
matchesStates:
| 'init'
| 'ready'
| 'ready.idle'
| 'ready.logging'
| 'ready.refreshing'
| { ready?: 'idle' | 'logging' | 'refreshing' };
'tags': never;
| {ready?: 'idle' | 'logging' | 'refreshing'};
tags: never;
}
22 changes: 11 additions & 11 deletions machines/auth.typegen.ts
Original file line number Diff line number Diff line change
Expand Up @@ -2,8 +2,8 @@

export interface Typegen0 {
'@@xstate/typegen': true;
'internalEvents': {
'': { type: '' };
internalEvents: {
'': {type: ''};
'done.invoke.auth.authorized:invocation[0]': {
type: 'done.invoke.auth.authorized:invocation[0]';
data: unknown;
Expand All @@ -14,19 +14,19 @@ export interface Typegen0 {
data: unknown;
__tip: 'See the XState TS docs to learn how to strongly type this.';
};
'xstate.init': { type: 'xstate.init' };
'xstate.init': {type: 'xstate.init'};
};
'invokeSrcNameMap': {
invokeSrcNameMap: {
downloadFaceSdkModel: 'done.invoke.auth.authorized:invocation[0]';
generatePasscodeSalt: 'done.invoke.auth.introSlider:invocation[0]';
};
'missingImplementations': {
missingImplementations: {
actions: never;
delays: never;
guards: never;
services: never;
};
'eventsCausingActions': {
eventsCausingActions: {
requestStoredContext: 'xstate.init';
setBiometrics: 'SETUP_BIOMETRICS';
setContext: 'STORE_RESPONSE';
Expand All @@ -40,18 +40,18 @@ export interface Typegen0 {
| 'done.invoke.auth.authorized:invocation[0]'
| 'done.invoke.auth.introSlider:invocation[0]';
};
'eventsCausingDelays': {};
'eventsCausingGuards': {
eventsCausingDelays: {};
eventsCausingGuards: {
hasBiometricSet: '';
hasData: 'STORE_RESPONSE';
hasLanguageset: '';
hasPasscodeSet: '';
};
'eventsCausingServices': {
eventsCausingServices: {
downloadFaceSdkModel: 'LOGIN' | 'SETUP_PASSCODE';
generatePasscodeSalt: 'SELECT';
};
'matchesStates':
matchesStates:
| 'authorized'
| 'checkingAuth'
| 'init'
Expand All @@ -60,5 +60,5 @@ export interface Typegen0 {
| 'savingDefaults'
| 'settingUp'
| 'unauthorized';
'tags': never;
tags: never;
}
6 changes: 3 additions & 3 deletions machines/bleShare/request/requestMachine.typegen.ts
Original file line number Diff line number Diff line change
Expand Up @@ -66,11 +66,11 @@ export interface Typegen0 {
prependReceivedVc: 'VC_RESPONSE';
registerLoggers:
| 'DISCONNECT'
| 'DISMISS'
| 'RESET'
| 'xstate.after(DESTROY_TIMEOUT)#request.clearingConnection';
removeLoggers:
| 'DISCONNECT'
| 'DISMISS'
| 'RESET'
| 'SCREEN_BLUR'
| 'xstate.after(DESTROY_TIMEOUT)#request.clearingConnection'
| 'xstate.init';
Expand Down Expand Up @@ -105,7 +105,7 @@ export interface Typegen0 {
eventsCausingServices: {
advertiseDevice:
| 'DISCONNECT'
| 'DISMISS'
| 'RESET'
| 'xstate.after(DESTROY_TIMEOUT)#request.clearingConnection';
checkBluetoothService: 'NEARBY_ENABLED';
checkNearByDevicesPermission:
Expand Down
Loading
Loading