Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(INJI-472): update issuerScreen content #942

Merged
merged 5 commits into from
Oct 22, 2023

Conversation

KiruthikaJeyashankar
Copy link
Contributor

@KiruthikaJeyashankar KiruthikaJeyashankar commented Oct 19, 2023

Changes involved

  • Content change in Issuers screen issuer description & page description
  • Hindi / kannada text parts / matras getting hidden is fixed
  • Loader
    1 Show setting up loader when user presses on download via eSignet
    2 Show downloading credentials loader on successful authorization via web view
    3 Disable back action in Loader for Android
  • Other fix 3.1 Showing wrong loader message when retied from error screen of any errors happened after user presses download via eSignet

modify IssuersScreen page description and issuer description

Signed-off-by: Kiruthika Jeyashankar <[email protected]>
@KiruthikaJeyashankar KiruthikaJeyashankar force-pushed the inji-472-update-content-vc-userflow branch from eecbb26 to c25ed34 Compare October 19, 2023 04:55
@swatigoel swatigoel requested a review from vijay151096 October 20, 2023 04:57
IssuersScreen was hiding matras in hindi text displayed, padding is added to resolve this

Signed-off-by: Kiruthika Jeyashankar <[email protected]>
…content-vc-userflow

Signed-off-by: Kiruthika Jeyashankar <[email protected]>
@KiruthikaJeyashankar KiruthikaJeyashankar force-pushed the inji-472-update-content-vc-userflow branch from 9dfb2aa to c4355da Compare October 20, 2023 07:31
hardware back button press or gesture back action is disable in loader

Signed-off-by: Kiruthika Jeyashankar <[email protected]>
@swatigoel swatigoel merged commit c9afb89 into mosip:develop Oct 22, 2023
3 checks passed
vijay151096 added a commit that referenced this pull request Oct 26, 2023
* feat(INJI-403): add events in the VC download flow for success scenario

* refactor(INJI-403): updates logic to capture preferred language in telemetry

Signed-off-by: Alka <[email protected]>

* fix(INJI-403): revert changes of google services and env added by mistake

Signed-off-by: Alka <[email protected]>

* refactor(INJI-403): extracts some methods of telemetry to a util file

Signed-off-by: Alka <[email protected]>

* fix(INJI-403): fetch selected issuer's id from context instead of event

Signed-off-by: Alka <[email protected]>

* feat(INJI-403): update telemetry package link to mosip org

Signed-off-by: Alka <[email protected]>

* Inji-406: tampered vc issue (#923)

* feat(inji-406): store vc before storing hmac to avoid race condition

Signed-off-by: Tilak Puli <[email protected]>

* feat(inji-406): waiting until vc saved completely before displaying VC card

Signed-off-by: Tilak Puli <[email protected]>

---------

Signed-off-by: Tilak Puli <[email protected]>

* feat(INJI-443): remove ellipse from QR login flow (#922)

Signed-off-by: Pooja Babusingh <[email protected]>
Co-authored-by: Pooja Babusingh <[email protected]>

* feat(INJI-403): making language code mapping fail safe and removing unwanted code

Signed-off-by: Alka <[email protected]>

* feat[INJI-403]: Add events in the VC download flow for success scenario (#908)

* feat(INJI-403): add events in the VC download flow for success scenario

* refactor(INJI-403): updates logic to capture preferred language in telemetry

Signed-off-by: Alka <[email protected]>

* fix(INJI-403): revert changes of google services and env added by mistake

Signed-off-by: Alka <[email protected]>

* refactor(INJI-403): extracts some methods of telemetry to a util file

Signed-off-by: Alka <[email protected]>

* fix(INJI-403): fetch selected issuer's id from context instead of event

Signed-off-by: Alka <[email protected]>

* feat(INJI-403): update telemetry package link to mosip org

Signed-off-by: Alka <[email protected]>

* feat(INJI-403): making language code mapping fail safe and removing unwanted code

Signed-off-by: Alka <[email protected]>

---------

Signed-off-by: Alka Prasad <[email protected]>
Signed-off-by: Alka <[email protected]>

* fix(INJI-403): update commit id of telemetry sdk

Signed-off-by: Alka <[email protected]>

* Update Telemetry SDK commit Id (#925)

* feat(INJI-403): add events in the VC download flow for success scenario

* refactor(INJI-403): updates logic to capture preferred language in telemetry

Signed-off-by: Alka <[email protected]>

* fix(INJI-403): revert changes of google services and env added by mistake

Signed-off-by: Alka <[email protected]>

* refactor(INJI-403): extracts some methods of telemetry to a util file

Signed-off-by: Alka <[email protected]>

* fix(INJI-403): fetch selected issuer's id from context instead of event

Signed-off-by: Alka <[email protected]>

* feat(INJI-403): update telemetry package link to mosip org

Signed-off-by: Alka <[email protected]>

* feat(INJI-403): making language code mapping fail safe and removing unwanted code

Signed-off-by: Alka <[email protected]>

* fix(INJI-403): update commit id of telemetry sdk

Signed-off-by: Alka <[email protected]>

---------

Signed-off-by: Alka Prasad <[email protected]>
Signed-off-by: Alka <[email protected]>
Signed-off-by: Swati Goel <[email protected]>
Co-authored-by: Swati Goel <[email protected]>

* fix(Inji 332): reset UIN field in add vc modal and set AddVcModal dropdown to VID (#864)

* fix(INJI-332): reset the UIN field in AddVcModal after downloading the VC using AID and show VID in dropdown

* refactor(INJI-332): remove unnecessary formatting changes

* fix(INJI-332): change default value of getIndividualId response to UIN in getVcModal

Signed-off-by: PuBHARGAVI <[email protected]>

* remove project.pbxproj changes

* Revert "remove project.pbxproj changes"

This reverts commit ba7d9ec.

* fix(INJI-332): reset the project.pbxproj file

Signed-off-by: PuBHARGAVI <[email protected]>

---------

Signed-off-by: PuBHARGAVI <[email protected]>

* Fix(INJI-431):  Resolved that UI would support all screen sizes(folded-devices) & fixed language translation issues. (#920)

* fix(MOSIP-29275): make usesCleartextTraffic to false for more secure communication (#886)

* fix(MOSIP-29275): make usesCleartextTraffic to false for more secure communications

* fix(MOSIP-29275): override usesCleartextTraffic to false in main manifest

---------

Signed-off-by: Swati Goel <[email protected]>
Co-authored-by: Swati Goel <[email protected]>
Signed-off-by: anil_majji <[email protected]>

* MOSIP-29698 (#891)

Signed-off-by: anil_majji <[email protected]>

* Inji-409: debugging setup fix (#893)

* feat(inji-400): update package-lock.json

* feat(inji-400): move flipper config to separate file from app.ts

Signed-off-by: anil_majji <[email protected]>

* feat(inji-398): enable cleartextTrafficPermitted in debug mode (#895)

Signed-off-by: anil_majji <[email protected]>

* fix(INJI-397)error message for deleted vcfile (#875)

* fix(INJI-397)error message for deleted vcfile

* fix(INJI-397)refactor:log activity event

* fix(INJI-397)refactor:log activity event

* fix(INJI-397)refactor:comparing VCMetadata

Signed-off-by: anil_majji <[email protected]>

* fix(MOSIP-29272): remove paste option for pin inputs (#894)

Signed-off-by: anil_majji <[email protected]>

* Test runner support to run jar MOSIP-29698 (#898)

* MOSIP-29698

* Test runner support to run jar MOSIP-29698

* Update TestData.json

Signed-off-by: neeharikatech <[email protected]>

---------

Signed-off-by: neeharikatech <[email protected]>
Signed-off-by: anil_majji <[email protected]>

* feat(inji-406): add logs for debugging tampered vc issues (#900)

Signed-off-by: anil_majji <[email protected]>

* Adjusted bottom tab for different screen sizes

Signed-off-by: anil_majji <[email protected]>

* Added responsive bottom line for ID input

Signed-off-by: anil_majji <[email protected]>

* Updated the missing texts with case sensitive

Signed-off-by: anil_majji <[email protected]>

* Removed unused button text in Welcome screen

Signed-off-by: anil_majji <[email protected]>

---------

Signed-off-by: Swati Goel <[email protected]>
Signed-off-by: anil_majji <[email protected]>
Signed-off-by: neeharikatech <[email protected]>
Co-authored-by: Sreenadh S <[email protected]>
Co-authored-by: Swati Goel <[email protected]>
Co-authored-by: neeharikatech <[email protected]>
Co-authored-by: Tilak Puli <[email protected]>
Co-authored-by: srikanth716 <[email protected]>

* talisman check for pre-commit and pre-push hooks (#915)

* feat(INJI-413): add talisman check for pre-commit and pre-push hooks

Signed-off-by: Pooja Babusingh <[email protected]>

* feat(INJI-413): add yarn jetify to package.json

Signed-off-by: Pooja Babusingh <[email protected]>

---------

Signed-off-by: Pooja Babusingh <[email protected]>
Co-authored-by: Pooja Babusingh <[email protected]>

* feat(INJI-366): display clientName as per app lang in QR login flow (#924)

* feat(INJI-366): display clientName as per app lang in QR login consent and success screen

In case the app language is not supported, fallback client name is displayed

Co-authored-by: Swati Goel <[email protected]>
Signed-off-by: Kiruthika Jeyashankar <[email protected]>

* refactor(INJI-366): merge localized field function for different data types

Signed-off-by: Kiruthika Jeyashankar <[email protected]>

* refactor(INJI-366): fix type warnings while getting localized value

Signed-off-by: Kiruthika Jeyashankar <[email protected]>

* fix(INJI-366): modify type check in getLocalizedField

Signed-off-by: Kiruthika Jeyashankar <[email protected]>

---------

Signed-off-by: Kiruthika Jeyashankar <[email protected]>
Signed-off-by: Swati Goel <[email protected]>
Co-authored-by: Swati Goel <[email protected]>

* feat(Inji-402): track login & onboarding flow events in telemetry (#918)

* feat(INJI-402): track different flows of login and onboarding features in telemetry

Signed-off-by: PuBHARGAVI <[email protected]>

* feat(INJI-402): add missing events in the login flow

Signed-off-by: PuBHARGAVI <[email protected]>

* feat(INJI-402): track hardware keystore not supported error in telemetry

Signed-off-by: PuBHARGAVI <[email protected]>

* fix(INJI-402): send biometric event only when biometrics are enrolled in device

Signed-off-by: PuBHARGAVI <[email protected]>

* feat(INJI-402): send error event for every 5 passcode mismatch attempts

Signed-off-by: PuBHARGAVI <[email protected]>

* feat(INJI-402): add telemetry events to track passcode screen flow when biometrics change

Signed-off-by: PuBHARGAVI <[email protected]>

* feat(INJI-402): add subtype to impression and interact event

Signed-off-by: PuBHARGAVI <[email protected]>

* fix(INJI-402): remove additionalParamters in error event

Signed-off-by: PuBHARGAVI <[email protected]>

* feat(INJI-402): remove extra impression events and fix the biometrics reenabling flow

Signed-off-by: PuBHARGAVI <[email protected]>

* refactor(INJI-402): change getData method name to getStartEventData in telemetry utils

Signed-off-by: PuBHARGAVI <[email protected]>

* feat(INJI-402): don't show biometric failed alert message when user cancels the flow

Signed-off-by: PuBHARGAVI <[email protected]>

* refactor(INJI-402): change telemetry events name

Signed-off-by: PuBHARGAVI <[email protected]>

* fix(INJI-402): add missing functions in telemetry utils

Signed-off-by: PuBHARGAVI <[email protected]>

* refactor(INJI-402): add impression event in passcode screen and change Main to Home in event

Signed-off-by: PuBHARGAVI <[email protected]>

---------

Signed-off-by: PuBHARGAVI <[email protected]>

* feat(INJI-403): add interact and impression events in the VC download flow

Signed-off-by: Alka <[email protected]>

* feat(INJI-403): update interact and impression events in the VC download flow

Signed-off-by: Alka <[email protected]>

* Inji-411: vc load optimisation (#927)

* feat(inji-406): store vc before storing hmac to avoid race condition

Signed-off-by: Tilak Puli <[email protected]>

* feat(inji-406): waiting until vc saved completely before displaying VC card

Signed-off-by: Tilak Puli <[email protected]>

* feat(inji-411): read and cache vc files data on welcome screen

Signed-off-by: Tilak Puli <[email protected]>

* feat(inji-411): remove formatting for unnecessary files

Signed-off-by: Tilak Puli <[email protected]>

---------

Signed-off-by: Tilak Puli <[email protected]>

* refactor(INJI-403): update backend_error to const as it will not chnage

Signed-off-by: Alka <[email protected]>

* feat(INJI-471) - Update intro slide image with description. (#931)

Signed-off-by: Swati Goel <[email protected]>

* fix(INJI-260):refactor language setup and intro slider alignment in smaller display (#930)

Signed-off-by: Sri Kanth Kola <[email protected]>

* Fix(INJI-439)- Resolved while changing the language, VC detailes alignment not in proper (#935)

Signed-off-by: anil_majji <[email protected]>

* fix(INJI-403): update auto calling of download vc page on fresh launch (#934)

Signed-off-by: Alka <[email protected]>

* Inji 408 error popup after maximum retries vc download (#926)

* feat(INJI-408):Display error message after max retries of downloading vcs

Signed-off-by: Sri Kanth Kola <[email protected]>

* feat(INJI-408):refactor error message

Signed-off-by: Sri Kanth Kola <[email protected]>

* feat(INJI-408):refactor naming convention and remove empty space

Signed-off-by: Sri Kanth Kola <[email protected]>

* feat(INJI-408):refactor naming convention

Signed-off-by: Sri Kanth Kola <[email protected]>

---------

Signed-off-by: Sri Kanth Kola <[email protected]>

* Refactor(inji-429) : standardize issuers configuration (#937)

* refactor(inji-429): standardize the issuers configuration

Signed-off-by: Vijay <[email protected]>

* refactor(inji-249): optimise the issuers protocols implementations

Signed-off-by: Vijay <[email protected]>

* refactor(inji-249): remove unnecessary states and unused icons

Signed-off-by: Vijay <[email protected]>

---------

Signed-off-by: Vijay <[email protected]>

* Fix(INJI-439): Resolved warning from text style of MosipVCItemDetails component (#948)

* Fix(INJI-439)- Resolved while changing the language, VC detailes alignment not in proper

Signed-off-by: anil_majji <[email protected]>

* Fix(INJI-439): Resolved warning from text style of MosipVCItemDetails component

Signed-off-by: anil_majji <[email protected]>

---------

Signed-off-by: anil_majji <[email protected]>

* feat(INJI-458): show loading screen after closing of web view in OpenID4VCI flow (#932)

* perf(INJI-458): cache fixed result of custom keystore presence

Each call over the RN bridge can take significant user-visible time, and since
the result is used multiple times and cannot change for a device in runtime,
it can be computed once stored for later use.

Signed-off-by: Harsh Vardhan <[email protected]>

* feat(INJI-458): show loading for android h/w keystore check & generation

Signed-off-by: Harsh Vardhan <[email protected]>

* feat(INJI-472): show loader on issuer select

Co-authored-by: KiruthikaJeyashankar <[email protected]>
Signed-off-by: Harsh Vardhan <[email protected]>

* refactor(INJI-458): rename const name to isHardwareKeystoreExists

Signed-off-by: Harsh Vardhan <[email protected]>

---------

Signed-off-by: Harsh Vardhan <[email protected]>
Co-authored-by: KiruthikaJeyashankar <[email protected]>

* INJI-473) Code clean up and fixing metro errors/warnings (#947)

* feat(INJI-473) - Removed unused injiTourGuide action.

Signed-off-by: Swati Goel <[email protected]>

* feat(INJI-473) - Removed unused logKey action.

Signed-off-by: Swati Goel <[email protected]>

* feat(INJI-473) - Removed unused backendInfo api and state.

Signed-off-by: Swati Goel <[email protected]>

* feat(INJI-473) - simplify isPasscodeSet logic.

Signed-off-by: Swati Goel <[email protected]>

* feat(INJI-473) - Move logState to commonUtil to remove cyclic dependency.

Signed-off-by: Swati Goel <[email protected]>

* feat(INJI-473) - Delete unused code.

Signed-off-by: Swati Goel <[email protected]>

* feat(INJI-473) - Refactor code to use util function for iOS or isAndroid.

Signed-off-by: Swati Goel <[email protected]>

* feat(INJI-473) - Move Issuers_Key_Ref into utils.

Signed-off-by: Swati Goel <[email protected]>

* feat(INJI-473) - Remove profile related resource from setting screen

Signed-off-by: Swati Goel <[email protected]>

* feat(INJI-473) - Remove unused code for locales.

Signed-off-by: Swati Goel <[email protected]>

---------

Signed-off-by: Swati Goel <[email protected]>

* popup to cancel the download card (#944)

* feat(INJI-299): add popup component

Signed-off-by: Sreenadh S <[email protected]>

* feat(INJI-299): add language translations for the cancel dialog textfeilds

Signed-off-by: Pooja Babusingh <[email protected]>

* feat(INJI-299): refactor confirmation dialog props

Signed-off-by: Pooja Babusingh <[email protected]>

* feat(INJI-299): add cancel confirmation dialog in otp screen

Signed-off-by: Pooja Babusingh <[email protected]>

* feat(INJI-299): refactor confirmation dialog flow

Signed-off-by: Pooja Babusingh <[email protected]>

* feat(INJI-299): remove console logs

Signed-off-by: Pooja Babusingh <[email protected]>

* feat(INJI-299): style confirmation dialog elements

Signed-off-by: Pooja Babusingh <[email protected]>

* feat(INJI-299): refactor the cancel flow

Signed-off-by: Pooja Babusingh <[email protected]>

* feat(INJI-299): refactor to show id modal when in not cancel download state

Signed-off-by: Pooja Babusingh <[email protected]>

* feat(INJI-299): replace confirmation dialog with message overlay

Signed-off-by: Pooja Babusingh <[email protected]>

---------

Signed-off-by: Sreenadh S <[email protected]>
Signed-off-by: Pooja Babusingh <[email protected]>
Signed-off-by: PoojaBabusing <[email protected]>
Co-authored-by: Sreenadh S <[email protected]>
Co-authored-by: Pooja Babusingh <[email protected]>

* refactor(INJI-472): update issuerScreen content (#942)

* refactor(INJI-472): update issuer screen content

modify IssuersScreen page description and issuer description

Signed-off-by: Kiruthika Jeyashankar <[email protected]>

* refactor(INJI-472): move loader component styles to LoaderStyles

Signed-off-by: Kiruthika Jeyashankar <[email protected]>

* fix(INJI-472): hindi text matras getting hidden

IssuersScreen was hiding matras in hindi text displayed, padding is added to resolve this

Signed-off-by: Kiruthika Jeyashankar <[email protected]>

* refactor(INJI-472): disable back action in loader

hardware back button press or gesture back action is disable in loader

Signed-off-by: Kiruthika Jeyashankar <[email protected]>

---------

Signed-off-by: Kiruthika Jeyashankar <[email protected]>

* add missing imports and adjust buttons alignment (#953)

* feat(INJI-299): add missing imports and adjust buttons alignment

Signed-off-by: Pooja Babusingh <[email protected]>

* feat(INJI-299): add gradient button type

Signed-off-by: Pooja Babusingh <[email protected]>

---------

Signed-off-by: Pooja Babusingh <[email protected]>
Co-authored-by: Pooja Babusingh <[email protected]>

* feat(INJI-299): show otp screen while showing cancel Download popup (#954)

Signed-off-by: Pooja Babusingh <[email protected]>
Co-authored-by: Pooja Babusingh <[email protected]>

* Refactor(inji-472): refactoring api usage, fix warnings, and fix fabicon ui issue (#952)

* refactor(inji-472): refactoring api usage, fix warnings, and fix fab icon ui issue

Signed-off-by: Vijay <[email protected]>

* refactor(inji-472): remove masking in vc details page, add the testid for the download FAB icon

Signed-off-by: Vijay <[email protected]>

---------

Signed-off-by: Vijay <[email protected]>

* feat(INJI-499) - Remove unused code for google near by and firebase. (#963)

Signed-off-by: Swati Goel <[email protected]>

* language text getting truncated (#960)

* feat(INJI-486): add correct kannada language labels

Signed-off-by: Pooja Babusingh <[email protected]>

* feat(INJI-486): add padding to prevent kan lang text getting truncated

Signed-off-by: Pooja Babusingh <[email protected]>

---------

Signed-off-by: Pooja Babusingh <[email protected]>
Signed-off-by: PoojaBabusing <[email protected]>
Co-authored-by: Pooja Babusingh <[email protected]>

* Inji - 368 integrate iris scan android ios (#936)

* feat(INJI-368): Integrate irisScan for android and ios

Signed-off-by: adityankannan-tw <[email protected]>

* feat(INJI-368): Add path to the model file

Signed-off-by: adityankannan-tw <[email protected]>

* feat(INJI-368): Integrate irisScan for android and ios

Signed-off-by: adityankannan-tw <[email protected]>

* feat(INJI-368): Update package lock json

Signed-off-by: adityankannan-tw <[email protected]>

---------

Signed-off-by: adityankannan-tw <[email protected]>
Signed-off-by: adityankannan-tw <[email protected]>
Signed-off-by: Swati Goel <[email protected]>
Co-authored-by: Swati Goel <[email protected]>

* feat(INJI-369): add height to skip button in intro sliders (#964)

Signed-off-by: Pooja Babusingh <[email protected]>
Co-authored-by: Pooja Babusingh <[email protected]>

* revert(INJI-299): popup to cancel the download card

Co-authored-by: adityankannan-tw <[email protected]
.com>
Signed-off-by: Kiruthika Jeyashankar <[email protected]>

---------

Signed-off-by: Alka Prasad <[email protected]>
Signed-off-by: Alka <[email protected]>
Signed-off-by: Tilak Puli <[email protected]>
Signed-off-by: Pooja Babusingh <[email protected]>
Signed-off-by: Swati Goel <[email protected]>
Signed-off-by: PuBHARGAVI <[email protected]>
Signed-off-by: anil_majji <[email protected]>
Signed-off-by: neeharikatech <[email protected]>
Signed-off-by: Kiruthika Jeyashankar <[email protected]>
Signed-off-by: Sri Kanth Kola <[email protected]>
Signed-off-by: Vijay <[email protected]>
Signed-off-by: Harsh Vardhan <[email protected]>
Signed-off-by: Sreenadh S <[email protected]>
Signed-off-by: PoojaBabusing <[email protected]>
Signed-off-by: adityankannan-tw <[email protected]>
Signed-off-by: adityankannan-tw <[email protected]>
Co-authored-by: Alka <[email protected]>
Co-authored-by: Alka Prasad <[email protected]>
Co-authored-by: Tilak Puli <[email protected]>
Co-authored-by: PoojaBabusing <[email protected]>
Co-authored-by: Pooja Babusingh <[email protected]>
Co-authored-by: Swati Goel <[email protected]>
Co-authored-by: PuBHARGAVI <[email protected]>
Co-authored-by: Anil kumar M <[email protected]>
Co-authored-by: Sreenadh S <[email protected]>
Co-authored-by: neeharikatech <[email protected]>
Co-authored-by: srikanth716 <[email protected]>
Co-authored-by: vijay151096 <[email protected]>
Co-authored-by: Harsh Vardhan <[email protected]>
Co-authored-by: adityankannan-tw <[email protected]>
@KiruthikaJeyashankar KiruthikaJeyashankar deleted the inji-472-update-content-vc-userflow branch October 27, 2023 05:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants