[INJICERT-657] update default JWT algo & remove unused code

Signed-off-by: Harsh Vardhan <[email protected]>
mosip · Jan 6, 2025 · d923fec · d923fec
1 parent 6d16be5
commit d923fec
Showing 1 changed file with 2 additions and 8 deletions.
diff --git a/...er-service/src/main/java/io/mosip/kernel/signature/service/impl/SignatureServiceImpl.java b/...er-service/src/main/java/io/mosip/kernel/signature/service/impl/SignatureServiceImpl.java
@@ -601,10 +601,7 @@ public JWTSignatureResponseDto jwsSign(JWSSignatureRequestDto jwsSignRequestDto)
 		byte[] jwsSignData = SignatureUtil.buildSignData(jwsHeader, dataToSign);
 
 		SignatureProvider signatureProvider = SIGNATURE_PROVIDER.get(signAlgorithm);
-		if (Objects.isNull(signatureProvider)) {
-			signatureProvider = SIGNATURE_PROVIDER.get(SignatureConstant.JWS_PS256_SIGN_ALGO_CONST);
-		}
-
+
 		String signature = signatureProvider.sign(privateKey, jwsSignData, providerName);
 
 		StringBuilder signedData = new StringBuilder().append(jwsHeader.toBase64URL().toString())
@@ -654,7 +651,7 @@ public SignResponseDto signv2(SignRequestDtoV2 signatureReq) {
 			referenceId = signRefid;
 		}
 		String signAlgorithm = SignatureUtil.isDataValid(signatureReq.getSignAlgorithm()) ?
-				signatureReq.getSignAlgorithm(): SignatureConstant.ED25519_ALGORITHM;
+				signatureReq.getSignAlgorithm(): SignatureConstant.JWS_EDDSA_SIGN_ALGO_CONST;
 
 		SignatureCertificate certificateResponse = keymanagerService.getSignatureCertificate(applicationId,
 				Optional.of(referenceId), timestamp);
@@ -664,9 +661,6 @@ public SignResponseDto signv2(SignRequestDtoV2 signatureReq) {
         certificateResponse.getCertificateEntry().getChain();
         String providerName = certificateResponse.getProviderName();
 		SignatureProvider signatureProvider = SIGNATURE_PROVIDER.get(signAlgorithm);
-		if (Objects.isNull(signatureProvider)) {
-			signatureProvider = SIGNATURE_PROVIDER.get(SignatureConstant.JWS_PS256_SIGN_ALGO_CONST);
-		}
 		String signature = signatureProvider.sign(privateKey, dataToSign, providerName);
 		byte[] data = java.util.Base64.getUrlDecoder().decode(signature);
 		SignResponseDto signedData = new SignResponseDto();