fix(opencrvs-token-endpoint): update how access token is fetched from OpenCRVS #34
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… opencrvs Signed-off-by: Loganathan Sekar <[email protected]>
Signed-off-by: Loganathan Sekar <[email protected]>
loganathan-sekaran
force-pushed
the
opencrvs-token-patch
branch
from
4dafd12 to
fd1f37a
Compare
loganathan-sekaran
approved these changes
Feb 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi! I'm Pyry from OpenCRVS and thought I'd help you out in the API changes a bit.
OpenCRVS has gone through 2 changes which affect this intermediate API:
authenticateSystemClient-api has changed to an OAuth-compliant URL. The new usage is documented here&type=CRVS_OFFICEto the query, and also re-fetching for&type=ADMIN_STRUCTUREI've added the token changes to this PR.
In my understanding, the second point doesn't need changes, as the addresses are already fetched per id basis here: https://github.com/MonobikashDas/mosip-opencrvs/blob/develop/mediator/src/main/java/io/mosip/opencrvs/util/OpencrvsDataUtil.java#L288