MOSIP-38449 - /ftpchipdetail/v2 - Admin API review comments (#1101)

* MOSIP-38449 - /ftpchipdetail/v2 - Admin API review comments Signed-off-by: sudeep <[email protected]> * MOSIP-38449 - /ftpchipdetail/v2 - Admin API review comments Signed-off-by: sudeep <[email protected]> --------- Signed-off-by: sudeep <[email protected]>
mosip · Jan 16, 2025 · eb237c0 · eb237c0
1 parent 6347c38
commit eb237c0
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 4 deletions.
diff --git a/...agement-service/src/main/java/io/mosip/pms/device/controller/FTPChipDetailController.java b/...agement-service/src/main/java/io/mosip/pms/device/controller/FTPChipDetailController.java
@@ -237,7 +237,7 @@ public ResponseWrapper<FtpCertDownloadResponeDto> getPartnerCertificate(
 
 	/*
 	 * This endpoint has been deprecated since the release-1.3.x
-	 * It has been replaced by the new GET /ftpchipdetail/search/v2 endpoint.
+	 * It has been replaced by the new GET /ftpchipdetail/v2 endpoint.
 	 * The functionality provided by this API is now available in the new endpoint.
 	 * Please use the new endpoint for all future requests.
 	 */
@@ -246,7 +246,7 @@ public ResponseWrapper<FtpCertDownloadResponeDto> getPartnerCertificate(
 	@PostMapping("/search")
 	@PreAuthorize("hasAnyRole(@authorizedRoles.getPostftpchipdetailsearch())")
 	@Operation(summary = "Service to search ftp chip details - deprecated since release-1.3.x.",
-			description = "This endpoint has been deprecated since the release-1.3.x and replaced by the GET /ftpchipdetail/search/v2 endpoint.")
+			description = "This endpoint has been deprecated since the release-1.3.x and replaced by the GET /ftpchipdetail/v2 endpoint.")
 	public ResponseWrapper<PageResponseDto<FTPSearchResponseDto>> searchFtpChipDetails(
 			@RequestBody @Valid RequestWrapper<DeviceSearchDto> request) {
 		ResponseWrapper<PageResponseDto<FTPSearchResponseDto>> responseWrapper = new ResponseWrapper<>();
@@ -285,7 +285,7 @@ public ResponseWrapperV2<FtmCertificateDownloadResponseDto> getFtmCertificateDat
 	}
 
 	@PreAuthorize("hasAnyRole(@authorizedRoles.getGetpartnersftmchipdetails())")
-	@GetMapping(value = "/search/v2")
+	@GetMapping(value = "/v2")
 	@Operation(summary = "This endpoint retrieves a list of all FTM Chip details created by all the FTM Providers.",
 	description = "Available since release-1.3.x. This endpoint supports pagination, sorting, and filtering. It is configured for the role FTM_PROVIDER.")
 	@io.swagger.v3.oas.annotations.responses.ApiResponses(value = {

diff --git a/...ervice/src/test/java/io/mosip/pms/test/device/controller/FTPChipDetailControllerTest.java b/...ervice/src/test/java/io/mosip/pms/test/device/controller/FTPChipDetailControllerTest.java
@@ -419,7 +419,7 @@ public void getPartnersFtmDetailsTest() throws Exception {
 
 		Mockito.when(ftpChipDetailServiceImpl.getPartnersFtmChipDetails(sortFieldName, sortType, pageNo, pageSize, filterDto))
 				.thenReturn(responseWrapper);
-		mockMvc.perform(MockMvcRequestBuilders.get("/ftpchipdetail/search/v2")
+		mockMvc.perform(MockMvcRequestBuilders.get("/ftpchipdetail/v2")
 						.param("sortFieldName", sortFieldName)
 						.param("sortType", sortType)
 						.param("pageNo", String.valueOf(pageNo))