Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prolong default http_timeout #732

Merged
merged 2 commits into from
Feb 11, 2025

Conversation

traines-source
Copy link
Contributor

As discussed here and here, the default timeout for RT downloads of 10 seconds may be too short for large feeds, because it seems to encompass the entire transfer and not only until the first packet. As far as I understand, it can be increased without risking exceeding the 60 seconds interval because the downloads run in parallel. Increasing the timeout to 30 seconds has helped for Transitous.

For some reason, it does not seem to throw a timeout error, but returns some garbled protobuf out of which it even succeeds to read a very small number of trip updates. When testing locally, I do get a timeout error as expected.

Btw, I'm seeing in the logs of my DELFI RT feed mirror that some instance running at TU Darmstadt is also frequently hitting the 10s timeout. Would be interesting to know whether it also doesn't throw timeout errors.

(... and a typo fix)

@felixguendling
Copy link
Member

maybe the config to string test can be deleted?

@traines-source
Copy link
Contributor Author

I think it suffices for me to notice that such a test exists :) Ah and I see that the msvc failure was probably fixed with felixguendling/cista@e03a1ff.

@felixguendling felixguendling merged commit 2565af5 into motis-project:master Feb 11, 2025
9 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants