Updating the headerToModule def to only manipulate '.h' files.
#402
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
Will update after installing docker / testing locally. |
…e compatible on the versions supported by Qt.py
…he messages and seeing if the application/mainwindow is required for this to work.
…moved the headerToModule() to a top level of the Qt.py. This allowed the function itself to be tested and no longer relies on the variety of paths the code may take in the when calling the QtCompat.loadui().
… user. If an ImportError occurs, a second attempt is made using the headerToModule code. Tests have been updated to include a Python widget stored in a path using a name not available to the test suite directly. (IE: Not named 'tests').
…init__.py files for folders to allow importing. Tested on the Docker 2018 and passed all tests.
|
Looks good to me. Let me know when you're happy and we can merge this. |
|
I won't make any other changes if all is good. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#401
This is an attempt to have the least amount of impact on the existing functionality, and allow Python custom widgets paths to work.
The original
headerauthored by the user will always be attempted first. If it fails to import for the PySide implementation, a second attempt is made using the original Qt.pyheaderToModulefunction.