Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implment MDagModifier bindings #22

Merged
merged 15 commits into from
Jun 13, 2021

Commits on Jun 6, 2021

  1. Configuration menu
    Copy the full SHA
    782b3ef View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    0390753 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    504c432 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    64f18b0 View commit details
    Browse the repository at this point in the history

Commits on Jun 7, 2021

  1. Make DagModifier a subclass of DGModifier

    If you Google "pybind11 subclass" you will find a couple of threads
    on how to solve the problem, none of which worked in this scenario.
    
    The issue on the pybind github about subclasses (below) cites a way
    to subclass an existing binding that feels as robust as creating
    a class on the fly using type("MyClass", bases, attrs)
     -> pybind/pybind11#1193
    
    Another issue recommends using py:base, which has been deprecated.
     -> pybind/pybind11#17
    
    ...also it didn't work.
    
    It seems to me that because we are defining each class as an .inl rather
    than a .hpp or .cpp file, they are not aware of each other. To remedy
    this, I've included the MDGModifier binding in the MDagModifier file,
    with an pre-processor to prevent duplicate entries. Otherwise, the base
    class would be omitted in the main.cpp.
    
    I think this solution will work well when we get to other classes with
    many subclasses, like the whole MFn* tree.
    yantor3d committed Jun 7, 2021
    Configuration menu
    Copy the full SHA
    90d1aac View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    4bf96b0 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    0604e77 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    085c79a View commit details
    Browse the repository at this point in the history
  5. Fix typo in build_linux.sh

    yantor3d committed Jun 7, 2021
    Configuration menu
    Copy the full SHA
    c1b8778 View commit details
    Browse the repository at this point in the history

Commits on Jun 12, 2021

  1. Configuration menu
    Copy the full SHA
    491a2fd View commit details
    Browse the repository at this point in the history
  2. Fix missing endif

    yantor3d committed Jun 12, 2021
    Configuration menu
    Copy the full SHA
    41d91d7 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    ceb5bf6 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    80ee3d0 View commit details
    Browse the repository at this point in the history
  5. Add docker test linux script

    yantor3d committed Jun 12, 2021
    Configuration menu
    Copy the full SHA
    255cc01 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    d37b487 View commit details
    Browse the repository at this point in the history