-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implment MDagModifier bindings #22
Merged
Merged
Commits on Jun 6, 2021
-
Configuration menu - View commit details
-
Copy full SHA for 782b3ef - Browse repository at this point
Copy the full SHA 782b3efView commit details -
Configuration menu - View commit details
-
Copy full SHA for 0390753 - Browse repository at this point
Copy the full SHA 0390753View commit details -
Configuration menu - View commit details
-
Copy full SHA for 504c432 - Browse repository at this point
Copy the full SHA 504c432View commit details -
Configuration menu - View commit details
-
Copy full SHA for 64f18b0 - Browse repository at this point
Copy the full SHA 64f18b0View commit details
Commits on Jun 7, 2021
-
Make DagModifier a subclass of DGModifier
If you Google "pybind11 subclass" you will find a couple of threads on how to solve the problem, none of which worked in this scenario. The issue on the pybind github about subclasses (below) cites a way to subclass an existing binding that feels as robust as creating a class on the fly using type("MyClass", bases, attrs) -> pybind/pybind11#1193 Another issue recommends using py:base, which has been deprecated. -> pybind/pybind11#17 ...also it didn't work. It seems to me that because we are defining each class as an .inl rather than a .hpp or .cpp file, they are not aware of each other. To remedy this, I've included the MDGModifier binding in the MDagModifier file, with an pre-processor to prevent duplicate entries. Otherwise, the base class would be omitted in the main.cpp. I think this solution will work well when we get to other classes with many subclasses, like the whole MFn* tree.
Configuration menu - View commit details
-
Copy full SHA for 90d1aac - Browse repository at this point
Copy the full SHA 90d1aacView commit details -
Configuration menu - View commit details
-
Copy full SHA for 4bf96b0 - Browse repository at this point
Copy the full SHA 4bf96b0View commit details -
Configuration menu - View commit details
-
Copy full SHA for 0604e77 - Browse repository at this point
Copy the full SHA 0604e77View commit details -
Configuration menu - View commit details
-
Copy full SHA for 085c79a - Browse repository at this point
Copy the full SHA 085c79aView commit details -
Configuration menu - View commit details
-
Copy full SHA for c1b8778 - Browse repository at this point
Copy the full SHA c1b8778View commit details
Commits on Jun 12, 2021
-
Configuration menu - View commit details
-
Copy full SHA for 491a2fd - Browse repository at this point
Copy the full SHA 491a2fdView commit details -
Configuration menu - View commit details
-
Copy full SHA for 41d91d7 - Browse repository at this point
Copy the full SHA 41d91d7View commit details -
Configuration menu - View commit details
-
Copy full SHA for ceb5bf6 - Browse repository at this point
Copy the full SHA ceb5bf6View commit details -
Configuration menu - View commit details
-
Copy full SHA for 80ee3d0 - Browse repository at this point
Copy the full SHA 80ee3d0View commit details -
Configuration menu - View commit details
-
Copy full SHA for 255cc01 - Browse repository at this point
Copy the full SHA 255cc01View commit details -
Configuration menu - View commit details
-
Copy full SHA for d37b487 - Browse repository at this point
Copy the full SHA d37b487View commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.