-
Notifications
You must be signed in to change notification settings - Fork 133
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Airmeet Event Details connector with tests and documentation #1077
Conversation
@shaunagm since this is a new class, similar to the OpenField connector, do you have any flags? Unlike my PR, looks like Ankur used the APIConnector which is good! |
Overall this looks good. I am a little concerned about including completely untested code, especially given that this particular API seems to be inconsistent at times in what it returns. Is there any way to add test data so you can double-check? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm switching my status to "request changes" because it's my understanding that you're going to test out the last few endpoints in your production environment. Let me know once that's done and I'll approve + merge - or let me know if we need a different approach.
…racks (features that are available only in certain Airmeet plans).
@strangeways sorry about the failing tests, they're an unrelated issue we're trying to debug and shouldn't block merging (as long as the tests otherwise pass, which they do). I appreciate the warnings in the docstrings. IIRC that was the only issue that needed addressed before merging, so I will go ahead and merge this |
This connector adds support for Airmeet, a webinar platform.
Methods are included for everything listed in the Event Details API documentation. However, we don't currently have data in our account for booths, event tracks, or poll responses, so I haven't verified the data being returned from those.
This connector doesn't implement the Manage Registrations or Manage Events API methods.
Basic tests and documentation are included.