Remove support for Python 3.8 (& fix failing MacOs 3.9 tests) #1192
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shaunagm
force-pushed
the
remove-3.8-and-fix-3.9-test-failure
branch
from
baac199 to
752eb40
Compare
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| - name: Patch install error when using Python 3.9, limited dependencies, and MacOS | ||
| if: ${{ matrix.limited-dependencies }} == True and ${{ matrix.os }} == "macos-latest" and ${{ matrix.python-version }} == "3.9" | ||
| run: pip install --system psycopg2-binary==2.9.9 | ||
|
|
Check warning
Code scanning / Scorecard
Pinned-Dependencies Medium
There was a problem hiding this comment.
this seems solid and makes sense to me
|
This should close #1138 and #1066 Would love review on this workaround - the tests are passing now but I'm not an installation expert and want to double check I'm not missing anything |
shaunagm
changed the title
Comment on lines
+661
to
+666
| orig.add_column( | ||
| "uid", | ||
| lambda row: hashlib.md5( | ||
| str.encode("".join([str(x) for x in row])), usedforsecurity=False | ||
| ).hexdigest(), | ||
| ) |
There was a problem hiding this comment.
IDK what this section of code is, but these changes seem out of scope of this PR?
There was a problem hiding this comment.
ohh I see, it's checking for the python version being 3.9 or higher
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not sure what to do about the test failures of 3.9 and higher, but we can treat them separately.
For the record, there appear to be two distinct issues, a slightly older one where the combo of Mac, Python 3.9, and limited dependencies leads to a psycopg2 install error and then one that's an issue for all limited dependency installs related to this pydantic release - the latter issue will hopefully have an easy fix soon but I'm not sure about the former.