Use TableSchema in BigQuery Column List #1293
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
IanRFerguson
requested review from
shaunagm,
willyraedy,
KasiaHinkson,
austinweisgrau and
sharinetmc
|
not sure why the AirMeet test isn't passing the 
|
Coverage report
Click to see where and how coverage changed
This report was generated by python-coverage-comment-action |
||||||||||||||||||||||||
|
Removed AirMeet anyway, out of scope in this PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fix patches an inefficiency in the
GoogleBigQuery.get_columns_list()function ... writing aSELECT * FROM {{ TABLE }} LIMIT 1in BigQuery isn't recommended as the entire table will be scanned in the process.This PR updates the logic to leverage the underlying
schemadefinition, rather than querying against the table.