Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(actionnetwork): Edge case and cleaning up type checking #889

Merged

Conversation

talevy42
Copy link
Contributor

@talevy42 talevy42 commented Sep 9, 2023

Handle edge case where acitonnetwork doesn't return a person_id, and use pythonic style for testing types

Copy link
Contributor

@sharinetmc sharinetmc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@talevy42, thank you for adding the person_id check and for making the if patterns more inline with our parsons patterns! lgtm!

@sharinetmc sharinetmc merged commit 0b9db94 into move-coop:main Sep 14, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants