-
Notifications
You must be signed in to change notification settings - Fork 133
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
implement new hustle api call #903
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @nmannes! Welcome to Parsons! (Are you in the Slack? We'd love to have you)
Sorry for the delay in responding to this PR. I'm also sorry the tests didn't run automatically - I've fixed the settings so first-time contributors can still run tests. :)
From the tests, it looks like there's an issue with linting. You can follow the instructions here to fix it - let me know if you have any questions.
The only other issue is that we'll want a test for this new method. You can copy/base your test on existing tests in the test_hustle.py file. Again, let me know if you have any questions. Writing tests can be a little confusing, especially if you're unfamiliar with mocks. We've got a guide to using mocks in tests here. :)
Hi @nmannes what's the status of this? Would you like help with the tests? Happy to do a pairing session |
Yes, I do have a cal.com link - I DMed it to you on the parsons slack |
…into 10-09-hustle-api-update
Update: Shauna and I spoke and there was an issue trying to generate a hustle oath2 token from sandbox credentials. Will follow up after the holidays to see why that was no good |
After a bit of emailing back and forth we got credentials and were able to test this manually against a sandbox, so we're good to merge! :) |
This is my first PR, so i figured I'd do something pretty basic. I just implemented an additional API call in the Hustle module in accordance with their docs that I found in something tagged as a good first issue