Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add new core contributers #820

Merged
merged 2 commits into from
Nov 21, 2023
Merged

Add new core contributers #820

merged 2 commits into from
Nov 21, 2023

Conversation

sjahr
Copy link
Contributor

@sjahr sjahr commented Nov 14, 2023

Description

I'd propose to add these two as core contributes. Both have contributed a lot to moveit2 in the previous months:

Checklist

  • Tested modified webpage locally using the build_locally.sh script
  • While waiting for someone to review your request, please consider reviewing another open pull request to support the maintainers

sea-bass
sea-bass approved these changes Nov 14, 2023
View reviewed changes
Copy link
Contributor

@sea-bass sea-bass left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes!

Would you mind fixing the dead link that's failing CI as well? Linking to a CI run (which gets periodically deleted) is probably not a great idea anyhow.

@sjahr sjahr merged commit 7314895 into moveit:main Nov 21, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sea-bass sea-bass sea-bass approved these changes

@henningkayser henningkayser Awaiting requested review from henningkayser

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sjahr @sea-bass