Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Humble] Add sleep in setup of flaky PSM test fixture #3126

Merged
merged 1 commit into from
Nov 22, 2024
Merged

Conversation

sea-bass
Copy link
Contributor

@sea-bass sea-bass commented Nov 22, 2024

Description

This is the Humble version of #3124, in which the test was never disabled and continued to be flaky.

See my log of successful retries: https://github.com/moveit/moveit2/actions/runs/11966024737?pr=3126

Checklist

  • Required by CI: Code is auto formatted using clang-format
  • Extend the tutorials / documentation reference
  • Document API changes relevant to the user in the MIGRATION.md notes
  • Create tests, which fail without this PR reference
  • Include a screenshot if changing a GUI
  • While waiting for someone to review your request, please help review another open pull request to support the maintainers

Copy link

mergify bot commented Nov 22, 2024

Please target the main branch for development, we will backport the changes to humble for you if approved and if they don't break API.

@codecov-commenter
Copy link

codecov-commenter commented Nov 22, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 42.28%. Comparing base (ccf7e5c) to head (9d03c90).
Report is 17 commits behind head on humble.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           humble    #3126      +/-   ##
==========================================
- Coverage   51.15%   42.28%   -8.87%     
==========================================
  Files         382      668     +286     
  Lines       31902    57743   +25841     
  Branches        0     7323    +7323     
==========================================
+ Hits        16317    24411    +8094     
- Misses      15585    33147   +17562     
- Partials        0      185     +185     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

@sea-bass sea-bass changed the title Add sleep in setup of flaky PSM test fixture [Humble] Add sleep in setup of flaky PSM test fixture Nov 22, 2024
@sea-bass sea-bass marked this pull request as ready for review November 22, 2024 04:48
@TSNoble
Copy link
Contributor

TSNoble commented Nov 22, 2024

@sea-bass

Could we replace the sleep with waitForService call(s)? Additionally, could we keep the issue open, since this is more of a workaround than a fix of the race condition?

@sjahr
Copy link
Contributor

sjahr commented Nov 22, 2024

@sea-bass

Could we replace the sleep with waitForService call(s)? Additionally, could we keep the issue open, since this is more of a workaround than a fix of the race condition?

👍 Let's merge this workaround for now and keep the issue open until it is properly solved

@sjahr sjahr merged commit 92e8808 into humble Nov 22, 2024
7 checks passed
@sjahr sjahr deleted the psm-test-sleep branch November 22, 2024 09:23
@sea-bass
Copy link
Contributor Author

@sea-bass

Could we replace the sleep with waitForService call(s)? Additionally, could we keep the issue open, since this is more of a workaround than a fix of the race condition?

This is a good idea. I truly wonder what it is about the planning scene that makes this happen. Maybe getting a full robot description topic?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants