Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removes unused deprecation.h file #3128

Merged
merged 2 commits into from
Nov 23, 2024

Conversation

TSNoble
Copy link
Contributor

@TSNoble TSNoble commented Nov 22, 2024

Description

Port of moveit/moveit#2693
Removes deprecation.h, which itself is marked as deprecated and is unused throughout the codebase.

Checklist

  • Required by CI: Code is auto formatted using clang-format
  • Extend the tutorials / documentation reference
  • Document API changes relevant to the user in the MIGRATION.md notes
  • Create tests, which fail without this PR reference
  • Include a screenshot if changing a GUI
  • While waiting for someone to review your request, please help review another open pull request to support the maintainers

Copy link
Contributor

@mikeferguson mikeferguson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How can we possibly deprecate deprecation.h!

Also, "remove for noetic" - LOL

@codecov-commenter
Copy link

codecov-commenter commented Nov 22, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 46.00%. Comparing base (d754dbd) to head (1821806).
Report is 1 commits behind head on main.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3128      +/-   ##
==========================================
+ Coverage   45.63%   46.00%   +0.38%     
==========================================
  Files         482      483       +1     
  Lines       40432    40632     +200     
==========================================
+ Hits        18448    18690     +242     
+ Misses      21984    21942      -42     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

Copy link
Contributor

@sea-bass sea-bass left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hah, nice.

@sea-bass sea-bass merged commit 94a68c8 into moveit:main Nov 23, 2024
10 of 11 checks passed
@TSNoble TSNoble deleted the maintenance/removes-deprecated-header branch November 26, 2024 19:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants