Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ros2]: Fixed preempting of execution #363

Open
wants to merge 3 commits into
base: ros2
Choose a base branch
from
Open

[ros2]: Fixed preempting of execution #363

wants to merge 3 commits into from

Commits on May 26, 2022

  1. Fixed preempting of execution: Action server starts thread when accep… 

    …ting the goal so it does not block the server from accepting a cancel request. While client is waiting for the result future, repeatedly check if preempting was requested and send a cancel request if it was
    @wyattrees @JafarAbdi
    wyattrees authored and JafarAbdi committed May 26, 2022
    Configuration menu
    Copy the full SHA
    9cf3973 View commit details
    Browse the repository at this point in the history

  2. Use callback groups to be able to call cancellation while executing

    @JafarAbdi
    JafarAbdi committed May 26, 2022
    Configuration menu
    Copy the full SHA
    64690d0 View commit details
    Browse the repository at this point in the history

  3. Revert impl

    @JafarAbdi
    JafarAbdi committed May 26, 2022
    Configuration menu
    Copy the full SHA
    fcdce1e View commit details
    Browse the repository at this point in the history