Skip to content

Commit

Permalink
fix: fix escaping bug introduced by backtracking
Browse files Browse the repository at this point in the history
  • Loading branch information
@satazor
satazor committed Nov 7, 2024
1 parent bff0c87 commit 640d391
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions lib/util/escape.js
View file
Original file line number Diff line number Diff line change
Expand Up @@ -20,12 +20,12 @@ function escapeArgument(arg, doubleEscapeMetaChars) {

// Sequence of backslashes followed by a double quote:
// double up all the backslashes and escape the double quote
arg = arg.replace(/(?=\\*?)"/g, '$1$1\\"');
arg = arg.replace(/(?=(\\+?)?)\1"/g, '$1$1\\"');

// Sequence of backslashes followed by the end of the string
// (which will become a double quote later):
// double up all the backslashes
arg = arg.replace(/(?=\\*?)$/, '$1$1');
arg = arg.replace(/(?=(\\+?)?)\1$/, '$1$1');

// All other backslashes occur literally

Expand Down

4 comments on commit 640d391

@MelvinSc
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing this bug. A colleague of mine managed to update his project in the 3 hour timespan v7.0.4 was the latest version. It took us until now to find the issue with his build.

@JSRAInmob
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks,
JSRAInmob

@NullandBlock861222
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So I take it I caused something good to follow up behind for us all?

@NullandBlock861222
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Honestly I am all pretty much brand new to this code souring stuff my old life before my wreak I might have been a so called source code wisord. Maybe I will continue to tap into the much faster n smarter self,lol

Please sign in to comment.