Skip to content

Commit

Permalink
Bug 1930782 - show_bug.cgi is using subframe scrolling again
Browse files Browse the repository at this point in the history
  • Loading branch information
kyoshino committed Nov 26, 2024
1 parent 78346fc commit 7563d4d
Show file tree
Hide file tree
Showing 2 changed files with 26 additions and 13 deletions.
4 changes: 3 additions & 1 deletion extensions/BugModal/web/bug_modal.css
Original file line number Diff line number Diff line change
Expand Up @@ -917,7 +917,9 @@ td.flag-requestee {
}

.new-changes-link {
flex: none;
position: sticky;
top: calc(var(--global-header-height) + var(--private-bug-banner-height, 0px) + 8px);
z-index: calc(var(--global-header-z-index) - 1);
overflow: hidden;
box-sizing: border-box;
margin: 8px auto 0;
Expand Down
35 changes: 23 additions & 12 deletions skins/standard/global.css
Original file line number Diff line number Diff line change
Expand Up @@ -115,7 +115,7 @@

/** Global */
--global-header-height: 48px;
--bug-banner-height: 24px;
--global-header-z-index: 100;

/** Region */
--primary-region-border-radius: 4px;
Expand Down Expand Up @@ -933,29 +933,31 @@ input[type="radio"]:checked {
*/

#bugzilla-body {
flex: auto;
display: flow-root;
position: relative;
overflow: auto;
outline: none;
scroll-padding-top: 8px;
}

@media screen {
:root {
scroll-padding-top: calc(var(--global-header-height) + var(--private-bug-banner-height, 0px) + 8px);
}

body {
color: var(--application-foreground-color);
background-color: var(--application-background-color);
scrollbar-color: var(--scrollbar-color);
}

#wrapper {
padding-top: calc(var(--global-header-height) + var(--private-bug-banner-height, 0px));
}

#header {
position: fixed;
inset: 0;
display: flex;
flex-direction: column;
overflow: hidden;
width: 100%;
height: 100%;
inset: 0 0 auto;
z-index: var(--global-header-z-index);
}

#main-inner {
Expand All @@ -969,7 +971,6 @@ input[type="radio"]:checked {
*/

#header {
flex: none;
height: var(--global-header-height);
color: var(--application-header-foreground-color);
background-color: var(--application-header-background-color);
Expand Down Expand Up @@ -1067,6 +1068,10 @@ input[type="radio"]:checked {
box-shadow: none;
}

#header .dropdown-content {
z-index: calc(var(--global-header-z-index) + 1);
}

/**
* Global header: title
*/
Expand Down Expand Up @@ -1547,12 +1552,18 @@ input[type="radio"]:checked {
* Private group banner for confidential and security bugs
*/

:root:has(#private-bug-banner) {
--private-bug-banner-height: 24px;
}

#private-bug-banner {
flex: none;
position: fixed;
inset: var(--global-header-height) 0 auto;
z-index: calc(var(--global-header-z-index) - 1);
background-color: var(--confidential-bug-background-color);
color: #111;
box-sizing: border-box;
height: var(--bug-banner-height);
height: var(--private-bug-banner-height);
padding: 4px;
text-align: center;
-webkit-user-select: none;
Expand Down

0 comments on commit 7563d4d

Please sign in to comment.