Basti shader-rings #127
Merged
Basti shader-rings #127
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I have tried to tweak it a bit, i it should now find the right coords more accurate. TBF we might not get it 100% right, as we are trying to from pixelspace -> realtive float -> pixelspace again 😅 |
src/components/mz-rings.js
Outdated
| // Now we can calc the center of the box in pixelspace | ||
| const center = { | ||
| x: normOther.x + normOther.width / 2.0, | ||
| y: normOther.y + normOther.height + 17, |
There was a problem hiding this comment.
Where does the 17 come from here? I just tried bumping this to normOther.height + 20 and it looks a bit more centered.
Screen.Recording.2024-12-05.at.12.46.26.PM.mov
There was a problem hiding this comment.
That is a magic number q_q
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Screen.Recording.2024-12-02.at.17.58.19.mov