Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FXVPN-12 - Move Pill button into its own component #135

Merged
merged 2 commits into from
Dec 13, 2024
Merged

FXVPN-12 - Move Pill button into its own component #135

merged 2 commits into from
Dec 13, 2024

Conversation

strseb
Copy link
Collaborator

@strseb strseb commented Dec 9, 2024

No description provided.

@strseb
Copy link
Collaborator Author

strseb commented Dec 9, 2024

📚 $\text{Stack Overview}$

Pulls submitted in this stack:

This comment was automatically generated by st.

.box.connecting svg,
.box.connecting .timer,
.connecting .pill,
.connecting footer {
.connecting mz-pill .connecting footer {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need to separate these selectors with a comma?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Right! fixed!

Base automatically changed from basti/telementry to main December 10, 2024 15:14
This can be a re-usable button, so that we have this for the telemtry view, which also uses that.
Copy link
Member

@lesleyjanenorton lesleyjanenorton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@strseb strseb merged commit a8ae8ea into main Dec 13, 2024
5 checks passed
@strseb strseb deleted the fork_pill branch December 13, 2024 14:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants