Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Butter bar alerts! 🧈 #146

Merged
merged 9 commits into from
Dec 13, 2024
Merged

Butter bar alerts! 🧈 #146

merged 9 commits into from
Dec 13, 2024

Conversation

lesleyjanenorton
Copy link
Member

@lesleyjanenorton lesleyjanenorton commented Dec 12, 2024

Here we:

  • Add butter bar lit component
  • Add ButterBarService which manages alerts that should be shown in the UI

New strings in this PR

Screen.Recording.2024-12-12.at.10.26.50.AM.mov

src/background/butterBarService.js Show resolved Hide resolved
({ alertId }) => alertId !== id
);
this.dismissedAlerts.push(id);
return this.butterBarList.set(newAlertList);
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

property.set returns void. Should this return a value?

return (
addon.enabled &&
addon.permissions.includes("proxy") &&
addon.id !== "[email protected]"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

q__q oh wow how could i miss that.

@lesleyjanenorton lesleyjanenorton merged commit fbe06b3 into main Dec 13, 2024
5 checks passed
@lesleyjanenorton lesleyjanenorton deleted the butter-bar branch December 13, 2024 18:35
lesleyjanenorton added a commit that referenced this pull request Dec 14, 2024
This is a follow up to #146 because I overlooked the following
acceptance criteria:
`The warning disappears on its own when all proxy-setting extensions are
inactive / removed.`

Ergo, this PR:
- Automagically hides butter bar alerts when conflicting extensions are
disabled and removed
- Does not add these alerts to the list of dismissed alerts so that they
are eligible to be shown again, should the same conflict or another
conflict re-materialize
- Renames the fn exposed to the UI from `removeAlert` -> `dismissAlert` 
- Dismissed alerts _are_ added to the dismissed alert list and are not
shown again, regardless of the status of the conflict.

- Updates and adds tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants