-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Butter bar alerts! 🧈 #146
Merged
Merged
Butter bar alerts! 🧈 #146
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
strseb
approved these changes
Dec 13, 2024
src/background/butterBarService.js
Outdated
({ alertId }) => alertId !== id | ||
); | ||
this.dismissedAlerts.push(id); | ||
return this.butterBarList.set(newAlertList); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
property.set
returns void. Should this return a value?
return ( | ||
addon.enabled && | ||
addon.permissions.includes("proxy") && | ||
addon.id !== "[email protected]" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
q__q oh wow how could i miss that.
lesleyjanenorton
added a commit
that referenced
this pull request
Dec 14, 2024
This is a follow up to #146 because I overlooked the following acceptance criteria: `The warning disappears on its own when all proxy-setting extensions are inactive / removed.` Ergo, this PR: - Automagically hides butter bar alerts when conflicting extensions are disabled and removed - Does not add these alerts to the list of dismissed alerts so that they are eligible to be shown again, should the same conflict or another conflict re-materialize - Renames the fn exposed to the UI from `removeAlert` -> `dismissAlert` - Dismissed alerts _are_ added to the dismissed alert list and are not shown again, regardless of the status of the conflict. - Updates and adds tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here we:
New strings in this PR
Screen.Recording.2024-12-12.at.10.26.50.AM.mov