Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improvement: Allow disconnect from 'Connecting', with limits. #147

Merged
merged 4 commits into from
Dec 16, 2024

Conversation

lesleyjanenorton
Copy link
Member

@lesleyjanenorton lesleyjanenorton commented Dec 12, 2024

This PR:

  • Disables the toggle when the extension is connecting.
    Why:
    • Button mashing on the toggle when the extension is 'connecting' (meaning the VPN client is transitioning from StateOn to StateOnPartial) results in wonky/unexpected behavior.
    • The toggle already appears disabled when connecting. You wouldn't expect clicking on it to do anything.
  • Adds a 15 second timeout, after which the extension toggle is re-enabled (actually and visibly)
    Why:
    • If the toggle remains disabled, and the client never successfully transitions to 'StateOnPartial', the extension is stuck in the connecting state.

@lesleyjanenorton lesleyjanenorton changed the title Improvement: Disconnecting from connecting state Improvement: Allow disconnect from 'Connecting', with limits. Dec 12, 2024
@lesleyjanenorton lesleyjanenorton marked this pull request as ready for review December 12, 2024 21:30
@lesleyjanenorton lesleyjanenorton merged commit cd17527 into main Dec 16, 2024
5 checks passed
@lesleyjanenorton lesleyjanenorton deleted the new-disconnect-from-connecting branch December 16, 2024 23:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants