Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FXVPN-328: Enable telemetry by default #175

Merged
merged 1 commit into from
Jan 6, 2025
Merged

FXVPN-328: Enable telemetry by default #175

merged 1 commit into from
Jan 6, 2025

Conversation

lesleyjanenorton
Copy link
Member

This PR enables telemetry in the extension by default, even if the client is not installed. Note that in this state, although telemetry is 'enabled', pings won't be sent to Glean until the client has been installed and is able to do so.

@strseb
Copy link
Collaborator

strseb commented Dec 28, 2024

@lesleyjanenorton - i'd like to understand the motivation.
The flag will be poulated by the client anyway, which should be false per the telemetry guideline, no?

@lesleyjanenorton
Copy link
Member Author

Nope, the AC is now that telemetry is opt-out. This change sets telemetry to On by default, even if the extension is installed before the client is installed (granted, no pings will be sent until the client is installed).

Copy link
Collaborator

@strseb strseb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

r+wc.

A: I do suspect that this is against the extension guidelines, at least it's a darkpattern. But that is a discussion i can have with santiago.

B: Not sure this has the intended effect.
This is only the default value until the extension connects to the client, which will then propagate it's value, so we should either change that in the client (that is a can of worm we don't want to open) ooor we just change the UI that is on by default and only apply that once a user action has been done.

@lesleyjanenorton lesleyjanenorton merged commit bdee084 into main Jan 6, 2025
5 checks passed
@lesleyjanenorton lesleyjanenorton deleted the fxvpn-328 branch January 6, 2025 16:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants