Replace Taskcluster with GH? #31
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
strseb
force-pushed
the
basti/hello_gh_ci
branch
from
fa9aa0b to
f9616ce
Compare
lesleyjanenorton
approved these changes
Aug 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SOOOOO.
I'm done with the linter beeing mad at us for beeing a priviledged extension.
However https://github.com/mozilla-extensions/xpi-template/blob/main/taskcluster/xpi_taskgraph/signing.py#L19-L25
The taskgraph we use does not support "normal" extension signing.
If we go down the AMO route, we will submit the XPI to AMO anyway and not use autograph.
Given that i cannot stop taskgraph from trying to lint and complain that we are priliedged without removing taskgraph... lets just remove it.
I wrote a small CI that does the same thing and as bonus deploys our current main.xpi to gh pages, so we can use the Web-Install flow