Skip to content
This repository has been archived by the owner on Apr 6, 2022. It is now read-only.

Commit

Permalink
Merge #152
Browse files Browse the repository at this point in the history
152: Use version from package.json in non-development r=rehandalal a=mythmon

Taskcluster doesn't build from tags, so if we pull versions from tags we don't get the right thing. This should fix that for now.

Co-authored-by: Mike Cooper <[email protected]>
  • Loading branch information
bors[bot] and mythmon authored May 1, 2020
2 parents 61be2f5 + 4705831 commit 8c08217
Showing 1 changed file with 3 additions and 1 deletion.
4 changes: 3 additions & 1 deletion webpack.config.js
Original file line number Diff line number Diff line change
Expand Up @@ -142,12 +142,14 @@ module.exports = async (env, argv = {}) => {

async function getBuildInfo(isDevelopment) {
const rv = {
version: (await execOutput("git describe --dirty=-uc")).trim(),
commitHash: (await execOutput("git rev-parse HEAD")).trim(),
};

if (isDevelopment) {
rv.isDevelopment = true;
rv.version = (await execOutput("git describe --dirty=-uc")).trim();
} else {
rv.version = packageData.version;
}

if (rv.version.endsWith("-uc")) {
Expand Down

0 comments on commit 8c08217

Please sign in to comment.