Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding docker env variables to codebuild #659

Merged
merged 1 commit into from
Jun 2, 2021
Merged

Conversation

duallain
Copy link
Contributor

@duallain duallain commented Jun 2, 2021

rtucker wants to login to dockerhub to prevent api rate limit errors.
This change makes it so an ssm parameter store secret is available for the pipelines.

See #655

rtucker wants to login to dockerhub to prevent api rate limit errors.
This change makes it so an ssm parameter store secret is available for the pipelines.
@duallain duallain requested a review from rtucker-mozilla June 2, 2021 17:36
Copy link
Contributor

@rtucker-mozilla rtucker-mozilla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great

@duallain duallain merged commit 75d63c7 into master Jun 2, 2021
@duallain duallain deleted the dockerhub-login branch June 2, 2021 18:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants