Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add explicit maintenance window and backups #46

Merged

Conversation

bheesham
Copy link
Member

Jira: IAM-1502


Terraform plan for terraform/test
Terraform will perform the following actions:

  # aws_db_instance.dino_park_packs_db will be updated in-place
  ~ resource "aws_db_instance" "dino_park_packs_db" {
        address                               = "dino-park-packs-db-test-us-west-2.ct1yzfxfuap7.us-west-2.rds.amazonaws.com"
        allocated_storage                     = 10
        allow_major_version_upgrade           = true
        arn                                   = "arn:aws:rds:us-west-2:320464205386:db:dino-park-packs-db-test-us-west-2"
        auto_minor_version_upgrade            = true
        availability_zone                     = "us-west-2a"
      ~ backup_retention_period               = 0 -> 15
      ~ backup_window                         = "08:06-08:36" -> "02:00-02:59"
        ca_cert_identifier                    = "rds-ca-rsa2048-g1"
      ~ copy_tags_to_snapshot                 = false -> true
        db_subnet_group_name                  = "dino-park-packs-db-test-us-west-2"
        delete_automated_backups              = true
        deletion_protection                   = false
        enabled_cloudwatch_logs_exports       = []
        endpoint                              = "dino-park-packs-db-test-us-west-2.ct1yzfxfuap7.us-west-2.rds.amazonaws.com:5432"
        engine                                = "postgres"
        engine_version                        = "11.22"
        hosted_zone_id                        = "Z1PVIF0B656C1W"
        iam_database_authentication_enabled   = true
        id                                    = "dino-park-packs-db-test-us-west-2"
        identifier                            = "dino-park-packs-db-test-us-west-2"
        instance_class                        = "db.t3.micro"
        iops                                  = 0
        license_model                         = "postgresql-license"
      ~ maintenance_window                    = "sun:10:22-sun:10:52" -> "sat:03:00-sat:05:00"
        max_allocated_storage                 = 100
        monitoring_interval                   = 0
        multi_az                              = false
        option_group_name                     = "default:postgres-11"
        parameter_group_name                  = "default.postgres11"
        password                              = (sensitive value)
        performance_insights_enabled          = false
        performance_insights_retention_period = 0
        port                                  = 5432
        publicly_accessible                   = false
        replicas                              = []
        resource_id                           = "db-643FGGRBLGIEMCH53HFF22CZFI"
        security_group_names                  = []
        skip_final_snapshot                   = false
        status                                = "available"
        storage_encrypted                     = false
        storage_type                          = "gp2"
        tags                                  = {}
        username                              = "dinopark"
        vpc_security_group_ids                = [
            "sg-034ab563c9e967ace",
        ]
    }

Plan: 0 to add, 1 to change, 0 to destroy.

Terraform plan for terraform/prod
Terraform will perform the following actions:

  # aws_db_instance.dino_park_packs_db will be updated in-place
  ~ resource "aws_db_instance" "dino_park_packs_db" {
        address                               = "dino-park-packs-db-prod-us-west-2.ct1yzfxfuap7.us-west-2.rds.amazonaws.com"
        allocated_storage                     = 10
        allow_major_version_upgrade           = true
        arn                                   = "arn:aws:rds:us-west-2:320464205386:db:dino-park-packs-db-prod-us-west-2"
        auto_minor_version_upgrade            = true
        availability_zone                     = "us-west-2a"
      ~ backup_retention_period               = 0 -> 15
      ~ backup_window                         = "09:01-09:31" -> "02:00-02:59"
        ca_cert_identifier                    = "rds-ca-rsa2048-g1"
      ~ copy_tags_to_snapshot                 = false -> true
        db_subnet_group_name                  = "dino-park-packs-db-prod-us-west-2"
        delete_automated_backups              = true
        deletion_protection                   = false
        enabled_cloudwatch_logs_exports       = []
        endpoint                              = "dino-park-packs-db-prod-us-west-2.ct1yzfxfuap7.us-west-2.rds.amazonaws.com:5432"
        engine                                = "postgres"
        engine_version                        = "11.22"
        hosted_zone_id                        = "Z1PVIF0B656C1W"
        iam_database_authentication_enabled   = false
        id                                    = "dino-park-packs-db-prod-us-west-2"
        identifier                            = "dino-park-packs-db-prod-us-west-2"
        instance_class                        = "db.t3.micro"
        iops                                  = 0
        license_model                         = "postgresql-license"
      ~ maintenance_window                    = "fri:07:12-fri:07:42" -> "sat:03:00-sat:05:00"
        max_allocated_storage                 = 100
        monitoring_interval                   = 0
        multi_az                              = false
        option_group_name                     = "default:postgres-11"
        parameter_group_name                  = "default.postgres11"
        password                              = (sensitive value)
        performance_insights_enabled          = false
        performance_insights_retention_period = 0
        port                                  = 5432
        publicly_accessible                   = false
        replicas                              = []
        resource_id                           = "db-6XZIG34MX2IV73QMVNNH4G4U3U"
        security_group_names                  = []
        skip_final_snapshot                   = false
        status                                = "available"
        storage_encrypted                     = false
        storage_type                          = "gp2"
        tags                                  = {}
        username                              = "dinopark"
        vpc_security_group_ids                = [
            "sg-02b750ace18018caa",
        ]
    }

Plan: 0 to add, 1 to change, 0 to destroy.

@bheesham bheesham requested a review from dividehex November 19, 2024 20:27
Copy link
Contributor

@dividehex dividehex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🏹 Very nice! Approved

@bheesham
Copy link
Member Author

Both test and prod Terraform configs have been applied. They will come into effect in the next maintenance window (scheduled Soon ™️).

@bheesham bheesham merged commit d4bbb9a into mozilla-iam:master Nov 22, 2024
1 check passed
@bheesham bheesham deleted the explicit-maintenance-window-and-backups branch November 22, 2024 17:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants