OIDC Auth refactor and tests for TokenVerification #529
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bheesham
force-pushed
the
oidc_auth-refactor-and-test
branch
2 times, most recently
from
6256834 to
bb02fcd
Compare
This commit does not change any app functionality (it's only a rename). The tests were not running because the class was not named how pytest expects. Jira: [IAM-1443](https://mozilla-hub.atlassian.net/browse/IAM-1443)
Refactored TokenVerifier to make it easier to test, though there's probably more we can do here. The messages may find a better home closer to the templates, but that's a story for another day. We should now be resistant to a variety of errors around JWS/JWK (assuming I didn't miss any branches.) More tests to come! Jira: [IAM-1443](https://mozilla-hub.atlassian.net/browse/IAM-1443)
bheesham
force-pushed
the
oidc_auth-refactor-and-test
branch
from
bb02fcd to
fea64c5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In general:
TokenVerification,We should consider moving some of this closer to the templates, where we can make better use of Jinja's translation/safety features.