Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update AMI in cloudformation #37

Merged
merged 2 commits into from
Mar 21, 2022
Merged

Update AMI in cloudformation #37

merged 2 commits into from
Mar 21, 2022

Conversation

rvaralda
Copy link
Contributor

No description provided.

@rvaralda rvaralda requested a review from gene1wood March 10, 2022 20:01
@gene1wood
Copy link
Contributor

What process produced this new AMI that's referenced?

@gene1wood
Copy link
Contributor

And does it capture the manual change described in #36

@rvaralda
Copy link
Contributor Author

rvaralda commented Mar 10, 2022 •
edited
Loading

There is no process by now, I've created it manually.
Yes, I just created this new AMI, it must contain your changes.

@rvaralda rvaralda requested review from gene1wood, bkochendorfer, duallain and smarnach and removed request for gene1wood March 14, 2022 21:15
duallain
duallain approved these changes Mar 21, 2022
View reviewed changes
Copy link

@duallain duallain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems ok to me - changing the key seems reasonable, updating the ami is good. Some worries about the ami becoming orphaned at some point, but this is better than before so 👍 from me.

@rvaralda rvaralda merged commit c6bdc16 into master Mar 21, 2022
@rvaralda rvaralda deleted the upd-ami branch March 21, 2022 19:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@duallain duallain duallain approved these changes

@gene1wood gene1wood Awaiting requested review from gene1wood

@bkochendorfer bkochendorfer Awaiting requested review from bkochendorfer

@smarnach smarnach Awaiting requested review from smarnach

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rvaralda @gene1wood @duallain