Bugfix FXIOS-10574 Protection panel tweaks Design QA

[petruSt24]

📜 Tickets

Jira ticket
Github issue

💡 Description

Updated the design of the protection panel based on the feedback from design

📝 Checklist

You have to check all boxes before merging

• Filled in the above information (tickets numbers and description of your work)
• Updated the PR name to follow our PR naming guidelines
• Wrote unit tests and/or ensured the tests suite is passing
• When working on UI, I checked and implemented accessibility (minimum Dynamic Text and VoiceOver)
• If needed, I updated documentation / comments for complex code and public methods
• If needed, added a backport comment (example @Mergifyio backport release/v120)

[MattLichtenstein]

I noticed a few outstanding UI discrepancies between the current implementation and the spec. Are these supposed to accounted for?

Actual	Expected
Favicon background is a rounded rectangle	Favicon background should be circlular
The website title is bolded	The website title should not be bolded
Spacing + centering of text inside the box with the fox image is incorrect	Spacing between labels should be less, and content should be vertically centered
Privacy settings link has less leading margin	Privacy settings link should have equal leading margin as the "Clear cookies and site data" button above it

[petruSt24]

@MattLichtenstein thank you for the suggestions, I replaced the stackView with a UIView to fix the spacing issue and updated the margin for the settings link button, but the website title is not bolded and it uses the menu navigation bar, they should look the same

[MattLichtenstein]

@petruSt24 it looks like we are changing the font of the HeaderView title from body to headline in HeaderView::setupDetails. Seems like this, and the corner radius of the favicon are artifacts of the old tracking protection panel and seem to need updating

[MattLichtenstein]

The connection details title and status text also do not seem to be centered when one of the labels are taking up more than one line