Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix FXIOS-10696 Dismiss search bar when tap on the outside view in HistoryPanel #23276

Merged
merged 6 commits into from
Nov 26, 2024
Merged

Bugfix FXIOS-10696 Dismiss search bar when tap on the outside view in HistoryPanel #23276

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
c076fa2
dismiss search bar when tap on the outside view in HistoryPanel
gokulvenkat243 Nov 21, 2024
61dcb31
bug fixed when tap search text clear button dismiss the search bar in…
gokulvenkat243 Nov 21, 2024
6c52c6e
bug fixed when tap on the outside removed keyboard in search bar in H…
gokulvenkat243 Nov 22, 2024
96ca2b7
Added Cancel button to searchBar in HistoryPanel
gokulvenkat243 Nov 26, 2024
cc239e7
removed tapGestures to searchBar
gokulvenkat243 Nov 26, 2024
8c3cf1d
fixed swiftlint
gokulvenkat243 Nov 26, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions firefox-ios/Client/Frontend/Library/HistoryPanel/HistoryPanel+Search.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,11 @@ extension HistoryPanel: UISearchBarDelegate {
performSearch(term: searchText)
}

func searchBarCancelButtonClicked(_ searchBar: UISearchBar) {
bottomStackView.isHidden = true
searchBar.resignFirstResponder()
}

func startSearchState() {
updatePanelState(newState: .history(state: .search))
bottomStackView.isHidden = false
Expand Down
2 changes: 1 addition & 1 deletion firefox-ios/Client/Frontend/Library/HistoryPanel/HistoryPanel.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -97,6 +97,7 @@ class HistoryPanel: UIViewController,
searchbar.searchTextField.placeholder = self.viewModel.searchHistoryPlaceholder
searchbar.returnKeyType = .go
searchbar.delegate = self
searchbar.showsCancelButton = true
}

private lazy var tableView: UITableView = .build { [weak self] tableView in
Expand Down Expand Up @@ -176,7 +177,6 @@ class HistoryPanel: UIViewController,
setupLayout()
configureDataSource()
applyTheme()

// Update theme of already existing view
bottomStackView.applyTheme(theme: currentTheme())
}
Expand Down