Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug 1929832 - Mark dau-reporting ping as deprecated #23281

Merged

Conversation

badboy
Copy link
Member

@badboy badboy commented Nov 21, 2024

This also removes it from the baseline schedule and should stop it from
being sent. It will be fully removed at a later point.## 📜 Tickets
Jira ticket
Github issue

cc @thatswinnie

💡 Description

📝 Checklist

You have to check all boxes before merging

  • Filled in the above information (tickets numbers and description of your work)
  • Updated the PR name to follow our PR naming guidelines
  • Wrote unit tests and/or ensured the tests suite is passing
  • When working on UI, I checked and implemented accessibility (minimum Dynamic Text and VoiceOver)
  • If needed, I updated documentation / comments for complex code and public methods
  • If needed, added a backport comment (example @Mergifyio backport release/v120)

@badboy badboy requested a review from a team as a code owner November 21, 2024 13:58
@badboy
Copy link
Member Author

badboy commented Nov 21, 2024

hold off merging this please.

This also removes it from the baseline schedule and should stop it from
being sent. It will be fully removed at a later point.
@badboy badboy force-pushed the 1929832/renamed-usage-reporting branch from 4aab2f6 to aeeb9ef Compare November 22, 2024 15:44
@badboy
Copy link
Member Author

badboy commented Nov 22, 2024

Updated it, removed the metrics from the old ping. From my side this would be ready to land.

@mobiletest-ci-bot
Copy link

Messages
📖 Project coverage: 33.17%
📖 Edited 6 files
📖 Created 0 files

Client.app: Coverage: 31.26

File Coverage
TelemetryWrapper.swift 70.65%

Generated by 🚫 Danger Swift against aeeb9ef

@thatswinnie thatswinnie merged commit d16f53c into mozilla-mobile:main Nov 25, 2024
12 of 13 checks passed
clarmso pushed a commit that referenced this pull request Nov 25, 2024
* Bug 1929832 - Mark dau-reporting ping as deprecated

This also removes it from the baseline schedule and should stop it from
being sent. It will be fully removed at a later point.

* Bug 1929832 - Rename to `usage-reporting` ping and remove the info fields
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants