Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add FXIOS-10568 [ToS] Firefox iOS: Show Onboarding Links in Modal Browser #23311

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Add FXIOS-10568 [ToS] Firefox iOS: Show Onboarding Links in Modal Browser #23311

wants to merge 1 commit into from
+60 −2

Conversation

dicarobinho
Copy link
Collaborator

📜 Tickets

Jira ticket

💡 Description

Add the actions for the link buttons from the screen

📝 Checklist

You have to check all boxes before merging

  • Filled in the above information (tickets numbers and description of your work)
  • Updated the PR name to follow our PR naming guidelines
  • Wrote unit tests and/or ensured the tests suite is passing
  • When working on UI, I checked and implemented accessibility (minimum Dynamic Text and VoiceOver)
  • If needed, I updated documentation / comments for complex code and public methods
  • If needed, added a backport comment (example @Mergifyio backport release/v120)

@dicarobinho dicarobinho marked this pull request as ready for review November 22, 2024 11:06
@dicarobinho dicarobinho requested a review from a team as a code owner November 22, 2024 11:06
@dicarobinho
Copy link
Collaborator Author

With a demo URL
https://github.com/user-attachments/assets/1cd59389-f4e1-4d3e-a7f4-9b58e6da0ef1

@mobiletest-ci-bot
Copy link

Messages
📖 Project coverage: 33.14%
📖 Edited 2 files
📖 Created 0 files

Client.app: Coverage: 31.25

File Coverage
TermsOfServiceViewController.swift 0.0% ⚠️

Generated by 🚫 Danger Swift against db5fb85

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thatswinnie thatswinnie Awaiting requested review from thatswinnie

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dicarobinho @mobiletest-ci-bot