Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor FXIOS-10647 Remove crash alert (backport #23300) #23329

Open
wants to merge 1 commit into
base: release/v133
Choose a base branch
from
Open

Refactor FXIOS-10647 Remove crash alert (backport #23300) #23329

wants to merge 1 commit into from
+2 −48

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Nov 22, 2024

📜 Tickets

Jira ticket
Github issue

💡 Description

Remove the restore tabs alert

📝 Checklist

You have to check all boxes before merging

  • Filled in the above information (tickets numbers and description of your work)
  • Updated the PR name to follow our PR naming guidelines
  • Wrote unit tests and/or ensured the tests suite is passing
  • When working on UI, I checked and implemented accessibility (minimum Dynamic Text and VoiceOver)
  • If needed, I updated documentation / comments for complex code and public methods
  • If needed, added a backport comment (example @Mergifyio backport release/v120)
This is an automatic backport of pull request #23300 done by [Mergify](https://mergify.com).

@OrlaM @mergify
Refactor FXIOS-10647 Remove crash alert (#23300)
4fe4c4b 
* Remove crash alert

* Remove commented code

(cherry picked from commit 81f3240)
@mergify mergify bot requested a review from a team as a code owner November 22, 2024 16:54
@mergify mergify bot requested review from issammani and removed request for a team November 22, 2024 16:54
@mergify mergify bot mentioned this pull request Nov 22, 2024
Merged
6 tasks
@OrlaM OrlaM added the weekly-release Tagging backports for rapid release label Nov 22, 2024
@mobiletest-ci-bot
Copy link

Messages
📖 Project coverage: 32.66%
📖 Edited 1 files
📖 Created 0 files

Client.app: Coverage: 30.68

File Coverage
BrowserViewController.swift 4.71% ⚠️

Generated by 🚫 Danger Swift against 4fe4c4b

@OrlaM OrlaM requested review from OrlaM and removed request for issammani November 26, 2024 15:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@OrlaM OrlaM OrlaM approved these changes

At least 3 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
weekly-release Tagging backports for rapid release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mobiletest-ci-bot @OrlaM