Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix checkout caches on shared trust domains #21

Merged
merged 2 commits into from
Nov 21, 2023

Conversation

ahal
Copy link
Contributor

@ahal ahal commented Oct 25, 2023

No description provided.

@ahal ahal self-assigned this Oct 25, 2023
@ahal ahal requested a review from a team as a code owner October 25, 2023 15:34
@ahal ahal force-pushed the checkout_cache branch 3 times, most recently from 0c9aa8f to a52337c Compare October 25, 2023 17:42
@jcristau
Copy link

Looks like there's an unrelated issue with pytest-mock vs python 3.7 that's breaking tests; does this need a rebase on top of f874541?

ahal added 2 commits November 15, 2023 09:52
Since the template uses the `mozilla` trust domain, it's expected for
workers to run tasks for multiple unrelated projects. Therefore we don't
want to share a checkout cache between them (and especially not call
them all `src`).

This scopes the checkout cache to just the specific project as well as
renames it from `src` -> `${project}`.
@ahal ahal merged commit c340d23 into mozilla-releng:main Nov 21, 2023
8 checks passed
@ahal ahal deleted the checkout_cache branch November 21, 2023 22:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants