signingscript: autograph gcp migration step 2: test against gcp prod #1099
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bhearsum
force-pushed
the
autograph-steps-2
branch
from
61facf8 to
6ca0418
Compare
This patch adds another set of new formats that point at Autograph GCP prod. These entries contain equivalents for all current production formats, and use the exact same credentials the existing production formats. Where they differ are: * Different formats (so we can opt into them) * Different autograph URL * Ensure we use explicit keyids everywhere
bhearsum
force-pushed
the
autograph-steps-2
branch
from
ad22540 to
2d5d7b8
Compare
|
This has been tested as thoroughly as possible. I covered:
I was unable to test app services and glean due to not having anything except prod worker pools set up for them. (I don't think this is worth fixing as a blocker here, but I could be convinced otherwise.) I was also unable to test the mobile trust domain via staging-reference-browser due to it not being in projects.yml (being addressed in mozilla-releng/fxci-config#259), and I suspect that it is also does not have the firefoxci app installed. Again, I don't think this is worth blocking this on, but I could be convinced otherwise. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch adds another set of new formats that point at Autograph GCP prod. These entries contain equivalents for all current production formats, and use the exact same credentials the existing production formats. Where they differ are:
Note that this patch landing and being deployed should not end up changing how we sign anything on its own, it will merely make gcp prod available to dev and fake-prod workers.