Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unify admin and public docker images #1311

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Unify admin and public docker images #1311

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion api/Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,4 +17,4 @@ USER app

RUN poetry install --only main

CMD ["/app/docker.d/init.sh", "admin"]
ENTRYPOINT ["/bin/bash", "/app/docker.d/init.sh"]
20 changes: 0 additions & 20 deletions api/Dockerfile.public
View file
Open in desktop

This file was deleted.

4 changes: 3 additions & 1 deletion docker-compose.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@ services:
build:
context: api
dockerfile: Dockerfile
command: admin
ports:
- "8015:8015"
# Mounting these three specific volumes is done to ensure that autoreloading
Expand Down Expand Up @@ -45,7 +46,8 @@ services:
public:
build:
context: api
dockerfile: Dockerfile.public
dockerfile: Dockerfile
command: public
ports:
- "8016:8016"
# See comment on the api container for the reasoning behind these mounts
Expand Down