product-details: don't ask hg.mozilla.org for data we already have (bug 1936479) #1594
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ug 1936479) The l10n data for a shipped release is immutable, so there's no point gathering it over and over. This means get_primary_builds() needs to look at old_product_details as well. Fixes mozilla-releng#1582 Cherry-picked from commit cb45c55 (PR
When the latest devedition and firefox beta don't match, we still need to include the latest devedition release in firefox_primary_builds.json, which means we need a list of locales for it.
bhearsum
approved these changes
Dec 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Take two, this time with better devedition handling: we need to include the devedition version in firefox_primary_builds.json if it's not in sync with beta, which means we need to fetch l10n info for it in that case.
First commit here is the same that was in #1586 and reverted in #1590; second commit should fix the devedition case.