Bug 1619470: Add support for listening to hg.mozilla.org pulse messsages. #22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomprince
commented
Mar 25, 2020
| cli.StringSliceFlag{ | ||
| Name: "hgmo-repo", | ||
| Usage: "hg.mozilla.org repo to listend to pushes from (can be used multiple times)", | ||
| Value: &cli.StringSlice{"ci/ci-admin", "ci/ci-configuration"}, |
There was a problem hiding this comment.
Not sure if these should be hard-coded?
|
(also, this is currently untested) |
oremj
reviewed
Mar 27, 2020
tomprince
force-pushed
the
hgmo-support
branch
2 times, most recently
from
d7bcd00 to
b9a7c76
Compare
oremj
suggested changes
Apr 6, 2020
|
Added some test (with the docker-specific parts in #23 that this is based on). |
|
Would you mind rebasing this PR? |
|
Adding @moz-jvehent for security review. |
ajvb
reviewed
May 19, 2020
| if len(data.PushlogPushes) != 1 { | ||
| log.Printf("Message %s has %d pushlog pushes, only 1 supported", t, len(data.PushlogPushes)) | ||
| break | ||
| } |
There was a problem hiding this comment.
@tomprince and I have been discussing this outside of this PR, but need some sort of verification step here similar to https://github.com/mozilla-services/cloudops-deployment-proxy/blob/master/proxyservice/dockerhub_handler.go#L49
ajvb
approved these changes
Jun 9, 2020
|
@oremj I think this is ready for review. |
oremj
approved these changes
Jun 22, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is to support Bug 1619470, running `ci-admin automatically in cloudops's Jenkins instance. (cc: @edunham)
@oremj This shares a bunch of code with #18 but I realized that that may need a bit more thought on the exact interface that should have between taskcluster and jenkins, where-as I think the interface here is fairly obvious.