Integrate remote-settings-client #232
Conversation
Dexterp37
force-pushed
the
rs-client
branch
2 times, most recently
from
3c30b07
to
e2192bc
Compare
This is a WIP commit to test the integration
The Kinto server was not properly configured to track changes on non-main buckets. In tests we created collections and buckets on the fly and changes to these were not properly tracked. By creating collections on the fly exclusively in the 'main' bucket we make sure that any change is tracked by Kinto and that everything works as expected
| .unwrap_or(&settings.remote_settings.default_collection) | ||
| .clone(), | ||
| )?; | ||
| let mut remote_settings_client = remote_settings_client::Client::builder() |
There was a problem hiding this comment.
Previously we were utilizing a FileStorage, e.g. remote_settings_client.storage(Box::new(FileStorage.., do we want to do that again? cc @mythmon
There was a problem hiding this comment.
Yes, if we don't we'll be re-downloading attachments at every sync.
| // remote settings behave as expected. We use PUT here to overwrite | ||
| // the bucket transparently each time, since we don't really care | ||
| // about the stored metadata. |
There was a problem hiding this comment.
Will calling PUT here delete the underlying collections? This method gets called as a part of parallel test runs, so we don't want to delete the collections used by other tests. The integration tests are one of the primary users of /dev/kinto.ini, so we can change that to support the old method, if that's possible.
There was a problem hiding this comment.
Good point. I restored the POST
There was a problem hiding this comment.
Will calling PUT here delete the underlying collections?
No it won't
* Revert "Merge pull request #232 from Dexterp37/rs-client" - Integrate remote-settings-client * Revert "Merge pull request #260 from mozilla-services/kinto-url-with-v1" - Include `/v1` on the end of the remote settings URL we give to the RS client * Revert "Merge pull request #261 from mozilla-services/feat/259" don't hide inner errors in the log message * Revert "Merge pull request #262 from mozilla-services/gh-259" Fix intermittent failures with ReqwestClient
This fixes #221 and contributes to #218 .
This does not currently enable signature verification, but exclusively replaces the custom rs implementation with the remote-settings-client one.