Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug-1906021: strip whitespace from Android_CPU_ABI2 and other string fields #6824

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Commits on Nov 27, 2024

  1. bug-1906021: strip whitespace from Android_CPU_ABI2 and other string …

    …fields
    
    This changes the CopyFromRawCrashRule to strip the right side of string
    field values. I haven't seen anything in crash reports so far where
    whitespace at the end of a crash annotation value is significant so I
    think this is safe.
    
    If it turns out not to be safe, we can extend CopyFromRawCrashRule to
    look at a "transforms" field to glean how it should transform the value
    after copying it. This would be helpful for the increasing number of
    fields that are comma or semi-colon delimited, too.
    willkg committed Nov 27, 2024
    Configuration menu
    Copy the full SHA
    372fa12 View commit details
    Browse the repository at this point in the history