Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #1472: check attachments bundle #1473

Merged
merged 4 commits into from
Sep 12, 2024
Merged

Fix #1472: check attachments bundle #1473

merged 4 commits into from
Sep 12, 2024

Conversation

leplatrem
Copy link
Contributor

Fix #1472

@leplatrem leplatrem requested a review from a team as a code owner August 7, 2024 15:15
@leplatrem leplatrem marked this pull request as draft August 7, 2024 15:15
@leplatrem leplatrem mentioned this pull request Aug 27, 2024
Closed
@leplatrem leplatrem marked this pull request as ready for review September 10, 2024 14:56
@leplatrem leplatrem added the enhancement New feature or request label Sep 10, 2024
alexcottner
alexcottner approved these changes Sep 11, 2024
View reviewed changes
Copy link
Contributor

@alexcottner alexcottner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good except for the one commented out line

@leplatrem leplatrem merged commit 921f306 into main Sep 12, 2024
4 checks passed
@leplatrem leplatrem deleted the 1472-bundle-check branch September 12, 2024 09:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexcottner alexcottner alexcottner approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Implement a check to verify freshness and validity of bundles
2 participants
@leplatrem @alexcottner