Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #1484: keep only one status per client per source and per period #1487

Merged
merged 3 commits into from
Sep 10, 2024

Conversation

leplatrem
Copy link
Contributor

Fix #1484

Context: in the client uptake telemetry code, we send one status per sync and per collection (aka source), except for attachments, where we report a download_error on each attachment download. If all downloads fail, the status is reported as many times per source as they are attachments in the collection.

This change modifies the query so that we only take into account one status per client per source and per period.

Example of configuration and run:

[checks.remotesettings-uptake-release.error-rate]
description = "Error rate of all sources"
module = "checks.remotesettings.uptake_error_rate"
params.max_error_percentage = 7
params.ignore_status = [
    # Ignore errors unrelated to the pipeline.
    "network_error",
    "offline_error",
    "shutdown_error",
]
params.channels = ["release", "esr"]
params.period_hours = 3
ttl = 7200
tags = ["telemetry", "remotesettings", "delivery-pipeline"]
$ CONFIG_FILE=config-test.toml make check project=remotesettings-uptake-release check=error-rate

@leplatrem leplatrem requested a review from a team as a code owner September 10, 2024 15:31
@leplatrem leplatrem added the bug Something isn't working label Sep 10, 2024
@leplatrem leplatrem merged commit 70b2f76 into main Sep 10, 2024
4 checks passed
@leplatrem leplatrem deleted the 1484-keep-only-one-status branch September 10, 2024 16:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Correct uptake-release/error-rate check
3 participants