Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace Photoswipe react library #10144

Merged
merged 2 commits into from
Mar 3, 2021
Merged

Replace Photoswipe react library #10144

merged 2 commits into from
Mar 3, 2021

Conversation

willdurand
Copy link
Member

@willdurand willdurand commented Mar 2, 2021

Fixes mozilla/addons#13820
Fixes mozilla/addons#13993


It should be very similar to what we had before.

@willdurand willdurand requested a review from bobsilverberg March 2, 2021 20:01
@willdurand willdurand marked this pull request as ready for review March 2, 2021 20:01
Copy link
Contributor

@bobsilverberg bobsilverberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks for taking care of this @willdurand.

r+wc

src/amo/components/ScreenShots/index.js Outdated Show resolved Hide resolved
src/amo/components/ScreenShots/index.js Show resolved Hide resolved
src/amo/components/ScreenShots/index.js Outdated Show resolved Hide resolved
src/amo/components/ScreenShots/styles.scss Show resolved Hide resolved
@willdurand willdurand merged commit 0d752cc into master Mar 3, 2021
@willdurand willdurand deleted the photoswipe branch March 3, 2021 08:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Replace Photoswipe react library Warning about Autoprefixer browsers option when running yarn amo
2 participants