-
Notifications
You must be signed in to change notification settings - Fork 536
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Split diff by block type #22830
Split diff by block type #22830
Conversation
9321d21
to
4fea195
Compare
4fea195
to
d8f9fce
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is looking promising. I have some comments.
Co-authored-by: William Durand <[email protected]>
0e8d92e
to
790773b
Compare
Co-authored-by: William Durand <[email protected]>
790773b
to
1459119
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
r+wc, thanks
Suspect IssuesThis pull request was deployed and Sentry observed the following issues:
Did you find this useful? React with a 👍 or 👎 |
Relates to: #22826
Relates to: #22828
Fixes: mozilla/addons#15147
Description
Split
generate_diffs
to include diffs for both hard and soft blocks. This is required for both stashing and filter updates.Context
This patch is required by both of the linked PRs and to keep them independent we should land this (trivial) change first and rebase the other two.
Testing
This is a backaward compatible patch so automated testing is fine.
Checklist
#ISSUENUM
at the top of your PR to an existing open issue in the mozilla/addons repository.