Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Warning about Autoprefixer browsers option when running yarn amo #13820

Closed
bobsilverberg opened this issue Sep 17, 2020 · 5 comments · Fixed by mozilla/addons-frontend#10144
Closed
Assignees
Labels
qa:not_needed repository:addons-frontend Issue relating to addons-frontend
Milestone

Comments

@bobsilverberg
Copy link
Contributor

There is a new warning displayed when running the site locally:

Replace Autoprefixer browsers option to Browserslist config.
Use browserslist key in package.json or .browserslistrc file.

Using browsers option can cause errors. Browserslist config
can be used for Babel, Autoprefixer, postcss-normalize and other tools.

If you really need to use option, rename it to overrideBrowserslist.

Learn more at:
https://github.com/browserslist/browserslist#readme
https://twitter.com/browserslist

This could be related to the recent upgrade to autofixer. We should address this if possible.

@willdurand
Copy link
Member

I've seen this one but it seems to be quite old, I am not sure why we didn't see it before. I read some issues related to this message and it wasn't clear to me what we needed to do. We're using a .browserslistrc file and we don't configure autoprefixer with browsers in the webpack-common file.

@bobsilverberg
Copy link
Contributor Author

I've seen this one but it seems to be quite old, I am not sure why we didn't see it before. I read some issues related to this message and it wasn't clear to me what we needed to do. We're using a .browserslistrc file and we don't configure autoprefixer with browsers in the webpack-common file.

Yeah, that's what I've also just discovered. We seem to be doing exactly what they say we should be doing, so I'm not sure why this is showing up, or what we can do about it. I'll do a bit more digging and then just leave it, I guess.

@bobsilverberg
Copy link
Contributor Author

I think I found it! Please stand by...

@bobsilverberg
Copy link
Contributor Author

bobsilverberg commented Sep 17, 2020

@willdurand
Copy link
Member

I believe the problem is coming from: https://github.com/minhtranite/react-photoswipe/blob/master/postcss.config.js#L9

woah!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
qa:not_needed repository:addons-frontend Issue relating to addons-frontend
Development

Successfully merging a pull request may close this issue.

3 participants