fixes #138: adds and implements a CryptographyProvider trait #142
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jcjones
reviewed
Nov 18, 2020
There was a problem hiding this comment.
I'd say that this is going the right places, and I'd merge it right as-is, though we'd have to make ring an optional dependency before the next uplift to m-c.
I think we'll find that we need a richer interface for getting a dyn Key in/out than what's here, but that's an OK start, and nothing here would run afoul of patterns in NSS.
| @@ -51,6 +51,7 @@ serde = { version = "1.0", optional = true, features = ["derive"] } | |||
| serde_json = { version = "1.0", optional = true } | |||
| bytes = { version = "0.5", optional = true, features = ["serde"] } | |||
| base64 = { version = "^0.10", optional = true } | |||
| ring = "0.16" | |||
There was a problem hiding this comment.
gonna have to be a feature I think
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Was this the sort of thing you were thinking? It's still a bit of a work in progress - e.g. the right build flags aren't there.