[DO NOT merge] - Set retention on client_level tables for glean_usage tables #6815
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alekhyamoz
requested review from
badboy,
scholtzan,
akkomar,
kik-kik,
lucia-vargas-a and
a team
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
scholtzan
reviewed
Jan 15, 2025
| @@ -19,6 +19,7 @@ bigquery: | |||
| type: day | |||
| field: submission_date | |||
| require_partition_filter: true | |||
| expiration_days: 775 | |||
There was a problem hiding this comment.
Just out of curiosity, what number should be used for expiration days? I have seen 780 as well:
There was a problem hiding this comment.
In the recent data retention sync meeting, we discussed and decided to use 775. The above PR was before a number was finalized. Open to suggestions or discussions if needed.
There was a problem hiding this comment.
Should we change the 780 to 775 in a separate PR? To make it consistent?
There was a problem hiding this comment.
I have changed 780 to 775 for a couple of tables. This file is deprecated and I will add it to my to-be-deleted list
ql/moz-fx-data-shared-prod/firefox_ios_derived/active_users_aggregates_v1/metadata.yaml#L23
alekhyamoz
force-pushed
the
retention_glean_usage
branch
from
9aac4b4 to
d354e8f
Compare
alekhyamoz
force-pushed
the
retention_glean_usage
branch
from
fb438f1 to
051ee24
Compare
alekhyamoz
changed the title
This comment has been minimized.
This comment has been minimized.
badboy
approved these changes
Jan 16, 2025
This comment has been minimized.
This comment has been minimized.
alekhyamoz
force-pushed
the
retention_glean_usage
branch
from
3783a5d to
ecd153f
Compare
Integration report for "Add some more client level glean usage tables"
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As part of the data retention project, the final set of work would be setting the partitions before 775 days (on client-level tables) expire.
This PR will be merged only after January 28th.
As part of this PR 2 changes will be implemented
table_type: client_levelPlease note that
first_seentables are excluded from setting retention.Reviewer please valid for the tables you own or use. Also, please don't hesitate to tag the appropriate owners.